Add a fake devshell for impure packages #281
Conversation
|
A default should probably also be added so when users attempt to run |
|
Adding a default package allows the user to run both |
Co-authored-by: DavHau <hsngrmpf+github@gmail.com>
|
The case where |
|
This commit also modifies how the testing of the examples works, only running a check if impurities have been resolved, without this the default check would be run which errors as designed with the new behavior. |
| @@ -46,7 +46,9 @@ | |||
| && [ "$(nix flake show --json | jq 'select(.packages."x86_64-linux".default.name)')" != "" ]; then | |||
| nix eval --read-only --no-allow-import-from-derivation .#default.name | |||
| fi | |||
| nix flake check "$@" | |||
| if [ "$(nix flake show --json | jq 'select(.packages."x86_64-linux".resolveImpure)')" == "" ]; then | |||
There was a problem hiding this comment.
resolveImpure will not vanish, even if impurities have been resolved. We want to give the user the possibility to re-resolve, as this can be used to update the dependencies.
I think this change should not be necessary. If the tests were failing, then there is probably a problem caused by src/default.nix which should be fixed
This should make issues like #272 less common