Bump nixpkgs to commit that fixed poetry on m1. Update nodjs_alternat… #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive_builder example to build for m1.
phaer
requested changes
Jun 20, 2023
| @@ -16,7 +16,7 @@ Building 'Prettier@2.4.1'. | |||
| src, | |||
| }: | |||
| (dream2nix.lib.makeFlakeOutputs { | |||
| systems = ["x86_64-linux"]; | |||
| systems = ["x86_64-linux" "aarch64-darwin"]; | |||
There was a problem hiding this comment.
As you see in the test log, we can't currently test this. So we either need to exclude it from tests or get nix-community/infra#493 finished before merging if we include this in the example.
We could ofc just bump the flake lock in a separate PR if tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #519. Instead of changing the flake.nix instead just modified the flake.lock to refer to the newer commit per @phaer