-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype MacOS CI #542
base: main
Are you sure you want to change the base?
Prototype MacOS CI #542
Conversation
Excluded the formatting test since it is unlikely to be platform-dependent.
Thanks for this! What is pinned through |
@DanLipsitt I just noticed that most of these tests will be deprecated as soon as we switch over to v1. Having functional CI pipelines for macos is still valuable but maybe it makes sense to wait until we have switched over, to prevent unnecessary work. |
Thanks, @DavHau. Is there a v1 branch where it would make more sense to do this? I see @phaer's v1-test-runner branch and your new actions-macos-dave. I don't mind doing extra work if it will be useful to build on later, but I'm also happy to leave it to others if it's already being taken care of. |
The v1 code is living on main under the subdir You might want to play with it a little and track our progress via the issue linked above. During the next few days we plan to create more detailed issues and probably a project board for moving v1 forward. After that it should be easier to see how to get involved. |
Hello & thanks for your contribution @DanLipsitt ! It's a bit unlucky timing, due to the v1 switch as @DavHau wrote. We also started to use nix-community's hercules-ci.com account for a nix-native CI infra. I've started a branch to use those builders and it seems to work well in principle, even though some jobs are still broken atm: #576 So all in all I'd propose we continue with hercules ci and close this? |
This PR sets up Github Actions CI for MacOS. It uses a build matrix to run on both Mac and Linux builders. I've made some changes that affect the Linux build in the interest of getting this prototype working. If people are interested in this addition, I can go back add the conditional settings that will make the Linux build behave as it did before.
Changes
tests-format
on both Mac and Linux. That one doesn't appear to be platform-specific.cachix/install-nix-action
to v22. The release notes mention a MacOS issue with previous versions.nixpkgs
. The pinned version broke the Mac build.Discussion
I'm new to Nix, so I don't fully understand how requesting a specific
nixpkgs
version in the install phase interacts with theflake.lock
. The Linux tests pass after unpinning. It seems like it would be good to test against unstable as well as the pinned version anyway. If we want, we can put both in the build matrix.This PR was motivated by #474. The CI jobs exhibit failures of several different kinds, so the PR uncovers at least one issue unrelated to #474 (and might not overlap with it at all).