Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional v1 python use cases #543

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chaoflow
Copy link
Contributor

@chaoflow chaoflow commented Jul 1, 2023

@chaoflow
Copy link
Contributor Author

chaoflow commented Jul 1, 2023

@DavHau @phaer The requirements from requirementsFiles seem not to be available during buildPythonPackage, see

cd examples/v1-pip-compile
nix build .#pypkg1
error: builder for '/nix/store/c2jcc3x4zpfiqpp7iii5kkl873lqgaf7-python3.10-pypkg1-1.drv' failed with exit code 1;
       last 10 log lines:
       > Successfully built pypkg1
       > Finished creating a wheel...
       > Finished executing pipBuildPhase
       > installing
       > Executing pipInstallPhase
       > /build/pypkg1/dist /build/pypkg1
       > Processing ./pypkg1-1.0.0-py3-none-any.whl
       > ERROR: Could not find a version that satisfies the requirement cryptography (from pypkg1) (from versions: none)
       > ERROR: No matching distribution found for cryptography
       > 
       For full logs, run 'nix log /nix/store/c2jcc3x4zpfiqpp7iii5kkl873lqgaf7-python3.10-pypkg1-1.drv'.

Any ideas?

@DavHau
Copy link
Member

DavHau commented Jul 4, 2023

You might have figured this out by now, but we currently maintain our examples for v1 in v1/nix/modules/drvs. Maybe move the new example there, if you still think it's needed, as everything besides v1/ is supposed to be removed soon.

@chaoflow
Copy link
Contributor Author

chaoflow commented Jul 5, 2023

@DavHau Yes, I wanted to be picked up by CI, will move once the repo is cleaned up.

@chaoflow chaoflow changed the title Start v1 examples Additional v1 python use cases Jul 5, 2023
@chaoflow
Copy link
Contributor Author

chaoflow commented Jul 5, 2023

@DavHau I also updated title and description of this PR

@chaoflow
Copy link
Contributor Author

@DavHau @phaer I rebased to latest main and have a couple of issues:

  1. Do you have a suggestion how we can get rid of fa7d7b5 ?
  2. The examples/v1-pip-compile/flake.lock keeps changing for
cd examples/v1-pip-compile
nix build -L .#pypkg1
nix run -L .#pypkg1.config.lock.refresh
  1. nix build -L .#pypkg1 failes with
error: builder for '/nix/store/619k18a1blicssd0bnl6nlji9wh804wc-python3.10-pypkg1-1.drv' failed with exit code 1;
       last 10 log lines:
       > Successfully built pypkg1
       > Finished creating a wheel...
       > Finished executing pipBuildPhase
       > installing
       > Executing pipInstallPhase
       > /build/pypkg1/dist /build/pypkg1
       > Processing ./pypkg1-1.0.0-py3-none-any.whl
       > ERROR: Could not find a version that satisfies the requirement cryptography (from pypkg1) (from versions: none)
       > ERROR: No matching distribution found for cryptography
       > 
       For full logs, run 'nix log /nix/store/619k18a1blicssd0bnl6nlji9wh804wc-python3.10-pypkg1-1.drv'.

Let's disregard how the examples are named or where they live - I'd like to get things working and then move around.

@DavHau
Copy link
Member

DavHau commented Sep 5, 2023

@chaoflow Is this here still relevant or can it be closed?

@chaoflow
Copy link
Contributor Author

chaoflow commented Sep 6, 2023

@DavHau It's kind of superseded by https://github.com/chaoflow/dream2nix-pyenv, given that self-contained examples don't work from within the dream2nix repo.

What is you plan about that?

Shall we add a section in the docs to link to external examples?

@DavHau
Copy link
Member

DavHau commented Sep 6, 2023

We should make them self contained, and yes, please feel free to add you example to the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants