feat(buildPythonPackage): support new pyproject format #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
force-pushed
the
python-pyproject-format
branch
from
aad6251
to
3c6cfaa
Compare
phaer
approved these changes
May 1, 2024
|
So, ready to merge? |
|
NixOS/nixpkgs#271597 implemented a new format for python packages that is starting to get traction in nixpkgs/unstable (soon to become NixOS 24.05). That is a progress towards NixOS/nixpkgs#272178, which would be a massive improvement for dream2nix once completed. This first step just makes sure that `buildPythonPackage` supports the new arguments properly. Without this change, many dream2nix python derivations fail to build on nixos-unstable right now. Probably other python auto-builders should leverage these new options when available for the d2n user. That can be added later. @moduon MT-1075
yajo
force-pushed
the
python-pyproject-format
branch
from
0d9268c
to
4cd8cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NixOS/nixpkgs#271597 implemented a new format for python packages that is starting to get traction in nixpkgs/unstable (soon to become NixOS 24.05).
That is a progress towards NixOS/nixpkgs#272178, which would be a massive improvement for dream2nix once completed.
This first step just makes sure that
buildPythonPackagesupports the new arguments properly. Without this change, many dream2nix python derivations fail to build on nixos-unstable right now.Probably other python auto-builders should leverage these new options when available for the d2n user. That can be added later.
@moduon MT-1075