New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firefox: Add containersForce
#5057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I agree a |
Firefox, upon exit, creates the default containers.json file in place of the one that home-manager created. This leads to errors when switching to a new profile, as home-manager is careful with overwriting existing files. The added option toggles that behaviour. Closes: nix-community#4989
b082cf9
to
5ba6569
Compare
since I've enabled this, firefox crashes on nixos-rebuild (at least the one in focus). Does anyone else see that ? |
I've been using this for 2 weeks with no problem. I just tried again and it worked. |
I've also been using this ever since I created this PR, and across many |
working great for me, thanks! when to expect it in the master? |
Still using it and didn't notice anything. |
Thanks! Merged to master now 🙂 |
Description
Firefox, upon exit, creates the default containers.json file in place of the one that home-manager created. This leads to errors when switching to a new profile, as home-manager is careful with overwriting existing files. The added option toggles that behaviour.
Closes: #4989
I guess it would be best if this was inlined into the existing
containers
field, in a backwards compatible way; e.g.,but I haven't managed to make that work.
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
Maintainer CC
@rycee @kira-bruneau