Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyprlock: add module #5325

Merged
merged 1 commit into from May 10, 2024
Merged

Hyprlock: add module #5325

merged 1 commit into from May 10, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Apr 23, 2024

Description

Adding the hyprlock module, similar to #5324

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@fufexan

@khaneliman
Copy link
Contributor Author

@rycee rebased and resolved merge conflicts

@khaneliman khaneliman force-pushed the hyprlock branch 2 times, most recently from 7cb81ee to d3b934d Compare May 6, 2024 15:45
modules/programs/hyprlock.nix Outdated Show resolved Hide resolved
modules/programs/hyprlock.nix Show resolved Hide resolved
@rycee rycee merged commit c6ddd80 into nix-community:master May 10, 2024
3 checks passed
@rycee
Copy link
Member

rycee commented May 10, 2024

Thanks! Merged to master now 🙂

@khaneliman khaneliman deleted the hyprlock branch May 10, 2024 13:35
khaneliman added a commit to khaneliman/khanelinix that referenced this pull request May 10, 2024
khaneliman added a commit to khaneliman/khanelinix that referenced this pull request May 10, 2024
@nyabinary
Copy link

https://github.com/hyprwm/hyprlock/blob/main/nix/hm-module.nix
Does this reach feature parity with this?

@khaneliman
Copy link
Contributor Author

https://github.com/hyprwm/hyprlock/blob/main/nix/hm-module.nix Does this reach feature parity with this?

It is done slightly differently, that had nix named attributes and validation unique to each setting. This just validates you're passing in valid nix that can be converted into hyprlang. You can see a linked commit above where I migrated from the flake hm-module to using the home-manager module. Main difference being everything is nested under a settings attribute, the names for attributes need to match the actual hyprlock config names, and there are no default values injected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants