Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add O_SEARCH to all platforms supported by libc crate #2374

Merged
merged 8 commits into from
Apr 21, 2024
Merged

Add O_SEARCH to all platforms supported by libc crate #2374

merged 8 commits into from
Apr 21, 2024
+4 −2

Conversation

TheJonny
Copy link
Contributor

What does this PR do

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

Sorry, something went wrong.

TheJonny added 5 commits April 15, 2024 22:56
@TheJonny
add solarish and freebsd to O_SEARCH, as it exists in in the libc crate

Verified

This commit was signed with the committer’s verified signature. The key has expired.
thoughtpolice Austin Seipp
GPG key ID: 25D2038DEB08021D
Expired
Verified
Learn about vigilant mode
24cff1f
@TheJonny
fcntl/O_SEARCH: add description similiar to the posix manpage
Loading
Loading status checks…
02d0e91
@TheJonny
fcntl O_SEARCH oops - fix syntax
Loading
Loading status checks…
cfe3f9d
@TheJonny
fcntl O_SEARCH: add fuchsia
Loading
Loading status checks…
268847a
@TheJonny
O_SEARCH: changelog
Loading
Loading status checks…
30b8ffe
@TheJonny TheJonny changed the title Add O_SEARCH to freebsd and solarish Add O_SEARCH to freebsd, solarish, and fuchsia Apr 15, 2024
SteveLauC
SteveLauC reviewed Apr 15, 2024
View reviewed changes
@SteveLauC
Copy link
Member

Hi, thanks for contributing to Nix, this patch LGTM expect that alias:)

@TheJonny @SteveLauC
fcntl/OPath: no alias for single platform
Loading
Loading status checks…
eaab07b 
Co-authored-by: SteveLauC <stevelauc@outlook.com>
@TheJonny TheJonny mentioned this pull request Apr 16, 2024
Open
@TheJonny
Copy link
Contributor Author

Should we also add it in all the other platforms supported by libc that are not in the tier list of nix? that would be aix, wasi, emscripten ?

@SteveLauC
Copy link
Member

Should we also add it in all the other platforms supported by libc that are not in the tier list of nix? that would be aix, wasi, emscripten ?

Yeah, I think we can do this

@SteveLauC
Copy link
Member

Hi, would you still want to add this symbol for these platforms :)

TheJonny added 2 commits April 21, 2024 15:14
@TheJonny
O_SEARCH: also add aux, wasi, emscripten
Loading
Loading status checks…
4af9ec8
@TheJonny
O_SEARCH: updated added platforms in changelog
Loading
Loading status checks…
e025b56
@TheJonny
Copy link
Contributor Author

Hi, would you still want to add this symbol for these platforms :)

done - I just was scared by the long cfg line :)

@TheJonny
Copy link
Contributor Author

(I would also like to see it on apple, but it's currently missing from libc - rust-lang/libc#3659 )

@TheJonny TheJonny changed the title Add O_SEARCH to freebsd, solarish, and fuchsia Add O_SEARCH to all platforms supported by libc crate Apr 21, 2024
SteveLauC
SteveLauC approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SteveLauC SteveLauC added this pull request to the merge queue Apr 21, 2024
Merged via the queue into nix-rust:master with commit 7ffbd3c Apr 21, 2024
36 checks passed
@SteveLauC SteveLauC mentioned this pull request Apr 29, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveLauC SteveLauC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheJonny @SteveLauC