Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @WHenderson
Thanks for your contribution!
I don't have time to perform a full review right now.
I should be able to by the end of next week.
Replace `rf` with `rimraf`
Not all projects are built before being typedoc-ed. In these situations, source maps are not available
67a8a8d
to
0b0b241
Compare
Replace visitor pattern with mutating visitor pattern which enumerates all types as well as any nested types
0b0b241
to
0a98d91
Compare
Hi @WHenderson Sorry for the delay. I took the initiative of reordering the commits, in order to add the new examples before the visitor's refactoring. Turns out the new examples were already working without the refactoring (except for the Intersection but this was a bug in Typedoc itself, fixed here : TypeStrong/typedoc#1910) Ideally I'd like to have some examples that highlight the need for the refactoring. Thanks in advance. |
A large number of the types weren't correctly linking up in my main mono-repo, so I debugged through the generation steps and came up with this fix. As you can tell from the order of commits, I didn't use TDD and am surprised that all the types correctly linked even without the changes. If I find some time I'll see if I can create a test case that justifies the fix. Right now I'm just trying to get my repo to the stage I can make it public (sorting documentation and licensing). Thanks for taking the time though and also for creating this extension in the first place! |
Hi @WHenderson |
rm
withrimraf
in package scripts to support windows