Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynamic Partition Tools #51

Merged
merged 1 commit into from Dec 22, 2021
Merged

Add Dynamic Partition Tools #51

merged 1 commit into from Dec 22, 2021

Conversation

MoetaYuko
Copy link
Contributor

This PR adds tools to handle dynamic partitions (super.img), tested working on archlinux.

@MoetaYuko
Copy link
Contributor Author

BTW the library dependencies are not well-organized. Arguably each static/dynamic library should declare its dependencies via target_link_libraries and export its headers via target_include_directories, rather than handcrafting all deps when building the executable. Any plan to refactor in the future?

@nmeum
Copy link
Owner

nmeum commented Dec 10, 2021

BTW the library dependencies are not well-organized. Arguably each static/dynamic library should declare its dependencies via target_link_libraries and export its headers via target_include_directories, rather than handcrafting all deps when building the executable. Any plan to refactor in the future?

Yes, that's currently a bit messy indeed. I personally haven't gotten around to refactoring this part of the build system yet and I am not sure if I will have the time do to so in the foreseeable future but I would welcome contributions addressing this issue.

@MoetaYuko
Copy link
Contributor Author

@nmeum Now it passes the CI build in my fork, please double-check.

@MoetaYuko
Copy link
Contributor Author

bump, is this mergeable now?

@Johnnynator Johnnynator merged commit 049a305 into nmeum:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants