chore: PC-13744 Composite SLOs in examples and SDK e2e tests #516
+621
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion for normal and composite SLOs
ditrytus
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
…o PC-13744-composite-examples
nieomylnieja
requested changes
Aug 13, 2024
nieomylnieja
approved these changes
Aug 13, 2024
renovate bot
referenced
this pull request
in nobl9/sloctl
Aug 21, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/nobl9/nobl9-go](https://togithub.com/nobl9/nobl9-go) | `v0.84.0-rc4` -> `v0.84.0-rc5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nobl9/nobl9-go (github.com/nobl9/nobl9-go)</summary> ### [`v0.84.0-rc5`](https://togithub.com/nobl9/nobl9-go/releases/tag/v0.84.0-rc5) [Compare Source](https://togithub.com/nobl9/nobl9-go/compare/v0.84.0-rc4...v0.84.0-rc5) #### What's Changed - chore: Adjust release doc by [@​BSski](https://togithub.com/BSski) in [https://github.com/nobl9/nobl9-go/pull/513](https://togithub.com/nobl9/nobl9-go/pull/513) - chore: Update dependency cspell to v8.13.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/515](https://togithub.com/nobl9/nobl9-go/pull/515) - chore: Update dependency cspell to v8.13.3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/517](https://togithub.com/nobl9/nobl9-go/pull/517) - chore: PC-13881 Fix comment about composites 2.0 being unavailable by [@​BSski](https://togithub.com/BSski) in [https://github.com/nobl9/nobl9-go/pull/518](https://togithub.com/nobl9/nobl9-go/pull/518) - chore: PC-13744 Composite SLOs in examples and SDK e2e tests by [@​ditrytus](https://togithub.com/ditrytus) in [https://github.com/nobl9/nobl9-go/pull/516](https://togithub.com/nobl9/nobl9-go/pull/516) - fix: PC-13744 Removed anomaly config from composite e2e test by [@​ditrytus](https://togithub.com/ditrytus) in [https://github.com/nobl9/nobl9-go/pull/520](https://togithub.com/nobl9/nobl9-go/pull/520) - chore: Update dependency golangci/golangci-lint to v1.60.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/521](https://togithub.com/nobl9/nobl9-go/pull/521) - chore: Update dependency cspell to v8.14.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/522](https://togithub.com/nobl9/nobl9-go/pull/522) - chore: Update DEVELOPMENT.md by [@​nieomylnieja](https://togithub.com/nieomylnieja) in [https://github.com/nobl9/nobl9-go/pull/523](https://togithub.com/nobl9/nobl9-go/pull/523) - feat: add Replay support to Logic Monitor by [@​mkaras-nobl9](https://togithub.com/mkaras-nobl9) in [https://github.com/nobl9/nobl9-go/pull/510](https://togithub.com/nobl9/nobl9-go/pull/510) #### New Contributors - [@​ditrytus](https://togithub.com/ditrytus) made their first contribution in [https://github.com/nobl9/nobl9-go/pull/516](https://togithub.com/nobl9/nobl9-go/pull/516) **Full Changelog**: nobl9/nobl9-go@v0.84.0-rc4...v0.84.0-rc5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/nobl9/sloctl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwiZ29sYW5nIiwicmVub3ZhdGUiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Recently added SDK e2e tests were developed when Composite SLOs were not released yet. We need to close that test coverage gap.
Summary
The code that generates examples of SLOs now includes all variants for Composite SLOs. Few cases required special handling:
indicatorsection and don't have an association with data sourcesYAML examples were regenerated from updated code.
Makefilecontains small improvement that when running e2e tests locallyNOBL9_SDK_TEST_RUN_SEQUENTIAL_APPLY_AND_DELETEenv var is set totrue, because usually, tests run locally are run against smaller and slower dev environments.Fixed
check/generatetarget inMakefilethat was not checking generated yaml examples.Testing
Locally:
Run "End-to-end tests dispatch" workflow with and without sequential requests option:
https://github.com/nobl9/nobl9-go/actions/runs/10355310664/job/28662650970
https://github.com/nobl9/nobl9-go/actions/runs/10355329422/job/28662712884