Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: PC-13881 Fix comment about composites 2.0 being unavailable #518

Conversation

BSski
Copy link
Contributor

@BSski BSski commented Aug 13, 2024

Summary

Removed outdated comment about composites 2.0 being unavailable. Fixed a few other comments too.

@BSski BSski merged commit 37596ab into main Aug 13, 2024
5 checks passed
@BSski BSski deleted the PC-13881-remove-outdated-comment-about-composites-v2-being-unavailable branch August 13, 2024 12:01
renovate bot referenced this pull request in nobl9/sloctl Aug 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/nobl9/nobl9-go](https://togithub.com/nobl9/nobl9-go) |
`v0.84.0-rc4` -> `v0.84.0-rc5` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fnobl9%2fnobl9-go/v0.84.0-rc5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fnobl9%2fnobl9-go/v0.84.0-rc5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fnobl9%2fnobl9-go/v0.84.0-rc4/v0.84.0-rc5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fnobl9%2fnobl9-go/v0.84.0-rc4/v0.84.0-rc5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>nobl9/nobl9-go (github.com/nobl9/nobl9-go)</summary>

###
[`v0.84.0-rc5`](https://togithub.com/nobl9/nobl9-go/releases/tag/v0.84.0-rc5)

[Compare
Source](https://togithub.com/nobl9/nobl9-go/compare/v0.84.0-rc4...v0.84.0-rc5)

#### What's Changed

- chore: Adjust release doc by
[@&#8203;BSski](https://togithub.com/BSski) in
[https://github.com/nobl9/nobl9-go/pull/513](https://togithub.com/nobl9/nobl9-go/pull/513)
- chore: Update dependency cspell to v8.13.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/nobl9/nobl9-go/pull/515](https://togithub.com/nobl9/nobl9-go/pull/515)
- chore: Update dependency cspell to v8.13.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/nobl9/nobl9-go/pull/517](https://togithub.com/nobl9/nobl9-go/pull/517)
- chore: PC-13881 Fix comment about composites 2.0 being unavailable by
[@&#8203;BSski](https://togithub.com/BSski) in
[https://github.com/nobl9/nobl9-go/pull/518](https://togithub.com/nobl9/nobl9-go/pull/518)
- chore: PC-13744 Composite SLOs in examples and SDK e2e tests by
[@&#8203;ditrytus](https://togithub.com/ditrytus) in
[https://github.com/nobl9/nobl9-go/pull/516](https://togithub.com/nobl9/nobl9-go/pull/516)
- fix: PC-13744 Removed anomaly config from composite e2e test by
[@&#8203;ditrytus](https://togithub.com/ditrytus) in
[https://github.com/nobl9/nobl9-go/pull/520](https://togithub.com/nobl9/nobl9-go/pull/520)
- chore: Update dependency golangci/golangci-lint to v1.60.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/nobl9/nobl9-go/pull/521](https://togithub.com/nobl9/nobl9-go/pull/521)
- chore: Update dependency cspell to v8.14.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/nobl9/nobl9-go/pull/522](https://togithub.com/nobl9/nobl9-go/pull/522)
- chore: Update DEVELOPMENT.md by
[@&#8203;nieomylnieja](https://togithub.com/nieomylnieja) in
[https://github.com/nobl9/nobl9-go/pull/523](https://togithub.com/nobl9/nobl9-go/pull/523)
- feat: add Replay support to Logic Monitor by
[@&#8203;mkaras-nobl9](https://togithub.com/mkaras-nobl9) in
[https://github.com/nobl9/nobl9-go/pull/510](https://togithub.com/nobl9/nobl9-go/pull/510)

#### New Contributors

- [@&#8203;ditrytus](https://togithub.com/ditrytus) made their first
contribution in
[https://github.com/nobl9/nobl9-go/pull/516](https://togithub.com/nobl9/nobl9-go/pull/516)

**Full Changelog**:
nobl9/nobl9-go@v0.84.0-rc4...v0.84.0-rc5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am
every weekday,every weekend" (UTC), Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/nobl9/sloctl).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwiZ29sYW5nIiwicmVub3ZhdGUiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants