fix: memory leak when using nock with jest (#2572)

nock · Jan 28, 2024 · 7468cf1 · 7468cf1
1 parent ccfa96d
commit 7468cf1
Show file tree

Hide file tree

Showing 6 changed files with 4,951 additions and 1,361 deletions.
diff --git a/.github/workflows/continuous-integration.yaml b/.github/workflows/continuous-integration.yaml
@@ -80,6 +80,9 @@ jobs:
         run: npm ci --ignore-scripts --no-audit --no-progress --prefer-offline
       - name: Test
         run: npm run test
+      - name: Test jest
+        run: npm run test:jest
+        if: matrix.node-version >= 14
     strategy:
       fail-fast: false
       matrix:

diff --git a/lib/common.js b/lib/common.js
@@ -70,10 +70,7 @@ function overrideRequests(newRequest) {
     debug('- overriding request for', proto)
 
     const moduleName = proto // 1 to 1 match of protocol and module is fortunate :)
-    const module = {
-      http: require('http'),
-      https: require('https'),
-    }[moduleName]
+    const module = require(proto)
     const overriddenRequest = module.request
     const overriddenGet = module.get
 

diff --git a/lib/intercept.js b/lib/intercept.js
@@ -370,8 +370,6 @@ function activate() {
     throw new Error('Nock already active')
   }
 
-  overrideClientRequest()
-
   // ----- Overriding http.request and https.request:
 
   common.overrideRequests(function (proto, overriddenRequest, args) {
@@ -435,6 +433,8 @@ function activate() {
       }
     }
   })
+
+  overrideClientRequest()
 }
 
 module.exports = {