fix: correctly parse request without specified path (#1011)

fixes #1003
nock · Oct 28, 2017 · eac534b · eac534b
1 parent 269377e
commit eac534b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/lib/common.js b/lib/common.js
@@ -198,9 +198,11 @@ function stringifyRequest(options, body) {
 
   if (port) port = ':' + port;
 
+  var path = options.path ? options.path : '';
+
   var log = {
     method: method,
-    url: options.proto + '://' + options.hostname + port + options.path,
+    url: options.proto + '://' + options.hostname + port + path,
     headers: options.headers
   };
 

diff --git a/lib/interceptor.js b/lib/interceptor.js
@@ -339,7 +339,7 @@ Interceptor.prototype.matchIndependentOfBody = function matchIndependentOfBody(o
         , path = options.path
         , proto = options.proto;
 
-    path = path.split('?')[0];
+    path = path ? path.split('?')[0] : '';
 
     if (this.scope.transformPathFunction) {
         path = this.scope.transformPathFunction(path);

diff --git a/tests/test_intercept.js b/tests/test_intercept.js
@@ -5200,6 +5200,23 @@ test('match when query is specified with allowUnmocked (#490)', function (t) {
   });
 });
 
+test('correctly parse request without specified path (#1003)', function(t) {
+  nock.cleanAll();
+
+  var scope1 = nock('https://example.com')
+    .get('')
+    .reply(200);
+
+  https.request({hostname: 'example.com'}, function(res) {
+    t.equal(res.statusCode, 200);
+    res.on('data', function() {});
+    res.on('end', function() {
+      scope1.done();
+      t.end();
+    });
+  }).end();
+});
+
 test("teardown", function(t) {
   var leaks = Object.keys(global)
     .splice(globalCount, Number.MAX_VALUE);