fix: remove semver usage (#2531)

nock · Oct 19, 2023 · f7216e9 · f7216e9
1 parent dd417f0
commit f7216e9
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/tests/test_common.js b/tests/test_common.js
@@ -14,7 +14,6 @@
 const http = require('http')
 const { expect } = require('chai')
 const sinon = require('sinon')
-const semver = require('semver')
 const nock = require('..')
 
 const common = require('../lib/common')
@@ -477,8 +476,12 @@ it('`percentEncode()` encodes extra reserved characters', () => {
 describe('`normalizeClientRequestArgs()`', () => {
   it('should throw for invalid URL', () => {
     // See https://github.com/nodejs/node/pull/38614 release in node v16.2.0
-    const isNewErrorText = semver.gte(process.versions.node, '16.2.0')
-    const errorText = isNewErrorText ? 'Invalid URL' : 'example.test'
+    const [major, minor, patch] = process.versions.node.split('.').map(parseInt)
+    const useNewErrorText =
+      major > 16 ||
+      (major === 16 && minor > 2) ||
+      (major === 16 && minor === 2 && patch > 0)
+    const errorText = useNewErrorText ? 'Invalid URL' : 'example.test'
 
     // no schema
     expect(() => http.get('example.test')).to.throw(TypeError, errorText)