-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http.IncomingMessage destroy does not work properly #1669
Comments
Here's the docs: https://nodejs.org/api/http.html#http_message_destroy_error Seems like this would be a good addition to the mock surface. Would you like to make a PR? It's been a moment since I've looked at this, though I think the method would be added in |
yes I would like to contribute; I'll take a look at this, thanks for the code suggestions |
Awesome! Let us know if you have any questions. |
🎉 This issue has been resolved in version 11.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Calling `destroy` on the the response, with an error, not correctly propagates through the socket and then the request object. This aligns with Node's native functionality. Fixes: #1669
Calling `destroy` on the the response, with an error, not correctly propagates through the socket and then the request object. This aligns with Node's native functionality. Fixes: #1669
🎉 This issue has been resolved in version 11.2.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Calling `destroy` on the the response, with an error, not correctly propagates through the socket and then the request object. This aligns with Node's native functionality. Fixes: #1669
I'm not sure if is a bug or else but I've a situation where I rely on res.destroy to manually raise an error.
What is the expected behavior?
res.destroy should emit an
error
event and error is passed as an argument to any listeners on the eventWhat is the actual behavior?
res.destroy is never called or does not emit error
How to reproduce the issue
Versions
The text was updated successfully, but these errors were encountered: