remove semver usage #2531
Merged
remove semver usage #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
force-pushed
the
remove-semver-usage
branch
from
0b26e19
to
d5b1cfe
Compare
Uzlopak
force-pushed
the
remove-semver-usage
branch
from
d5b1cfe
to
09e95c8
Compare
|
🎉 This PR is included in version 13.3.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hmm odd that this merged, despite CI failing for Node 16 🤔 |
|
I think I found the culprit: #2538 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dont have semver as dependency or devDependency. It is only working because semver is installed for another devdependency. Theoretically we should add semver as devdependency to avoid breaking something if we remove the devdependency which uses semver. But we can avoid the necessity to use semver by directly using native code.