Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix Interceptor.filteringPath #1543

Merged
merged 2 commits into from
May 7, 2019
Merged

Bugfix Interceptor.filteringPath #1543

merged 2 commits into from
May 7, 2019

Commits on May 7, 2019

  1. Bugfix Interceptor.filteringPath 

    Calling `filteringPath` on the intercept instance was broken as the
transform fn set on the scope had the wrong name.
Proxying to the Scope’s method allows for the regex version to work too.
The bulk of the changed lines come from moving the tests to their
appropriate file since the real logic acts on the Scope.

Found when looking at Uncovered lines in coveralls.
    @mastermatt @paulmelnikow
    mastermatt authored and paulmelnikow committed May 7, 2019
    Configuration menu
    Copy the full SHA
    ee775b8 View commit details
    Browse the repository at this point in the history

  2. Update tests/test_intercept.js 

    Co-Authored-By: mastermatt <matt@mattw.co>
    @paulmelnikow @mastermatt
    paulmelnikow and mastermatt committed May 7, 2019
    Configuration menu
    Copy the full SHA
    79fea8e View commit details
    Browse the repository at this point in the history