Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Node 10+ #1895

Merged
merged 4 commits into from Feb 11, 2020
Merged

Require Node 10+ #1895

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d45bb6e
Require Node 10+
paulmelnikow Feb 11, 2020
0efbbea
Merge branch 'beta' into bump-node
paulmelnikow Feb 11, 2020
9ebc83d
10.0 -> 10.13
paulmelnikow Feb 11, 2020
02bd686
Merge branch 'beta' into bump-node
paulmelnikow Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/continuous-integration.yaml
View file
Open in desktop
Expand Up @@ -121,5 +121,5 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [8, 10, 12, 13]
node-version: [10, 12, 13]
os: [macos-latest, ubuntu-latest, windows-latest]
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@
"url": "http://github.com/nock/nock/issues"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the idea is to only support LTS, this should be >=10.13.
https://nodejs.org/en/download/releases/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think LTS and Active.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be supporting LTS Active and Maintenance.
https://nodejs.org/en/about/releases/
Otherwise we'd be dropping 10.x in two months.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ones we support on that chart are Current, Active, and Maintenance. Does that sound right?

},
"main": "./index.js",
"types": "types",
Expand Down