Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace LoDash isPlainObject, mapValues, and isMap #1963

Merged
merged 2 commits into from Mar 31, 2020
Merged

refactor: replace LoDash isPlainObject, mapValues, and isMap #1963

merged 2 commits into from Mar 31, 2020

Commits on Mar 29, 2020

  1. refactor: replace LoDash isPlainObject, mapValues, and isMap 

    - `isMap` was added to `util.types` in Node 10.0.
  https://nodejs.org/api/util.html#util_util_types_ismap_value
- `isPlainObject` and `mapValue` both came from LoDash's master branch, which is the pending v5.
- Replace LoDash dependency with `lodash.set` to cover the one use we still have.

Ref: nock#1285
    @mastermatt
    mastermatt committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    b85f914 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Merge branch 'beta' into 1285/isplainobject-mapvalue

    @mastermatt
    mastermatt committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    58bd37e View commit details
    Browse the repository at this point in the history