New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 Gregor's code review and refactor #2252
base: main
Are you sure you want to change the base?
Commits on Dec 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 267807d - Browse repository at this point
Copy the full SHA 267807dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 094091a - Browse repository at this point
Copy the full SHA 094091aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c986a22 - Browse repository at this point
Copy the full SHA c986a22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94c8fd3 - Browse repository at this point
Copy the full SHA 94c8fd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d7d26d - Browse repository at this point
Copy the full SHA 3d7d26dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed8a352 - Browse repository at this point
Copy the full SHA ed8a352View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64b4ddb - Browse repository at this point
Copy the full SHA 64b4ddbView commit details -
```js const got = require('got') const intercept = require('./modules/node-intercept') run() async function run() { const reset = intercept() console.log('Intercepted:') console.log(await got('https://example.com').text()) // logs "Hello, world!" console.log('\n\nNot Intercepted:') reset() console.log(await got('https://example.com').text()) // logs HTML from example.com } ```
Configuration menu - View commit details
-
Copy full SHA for 568a061 - Browse repository at this point
Copy the full SHA 568a061View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcae3f6 - Browse repository at this point
Copy the full SHA fcae3f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 768fbb3 - Browse repository at this point
Copy the full SHA 768fbb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e459734 - Browse repository at this point
Copy the full SHA e459734View commit details -
Configuration menu - View commit details
-
Copy full SHA for de2ebad - Browse repository at this point
Copy the full SHA de2ebadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b98be9 - Browse repository at this point
Copy the full SHA 7b98be9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95e0cf4 - Browse repository at this point
Copy the full SHA 95e0cf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 495b13d - Browse repository at this point
Copy the full SHA 495b13dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8131b72 - Browse repository at this point
Copy the full SHA 8131b72View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd072e4 - Browse repository at this point
Copy the full SHA cd072e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4abcba2 - Browse repository at this point
Copy the full SHA 4abcba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 374db48 - Browse repository at this point
Copy the full SHA 374db48View commit details -
fix: thow error if nocks
http.ClientRequest()
override is called wi……thout arguments. Check if response callback is set before using
Configuration menu - View commit details
-
Copy full SHA for 688d961 - Browse repository at this point
Copy the full SHA 688d961View commit details -
Revert "test: make existing test more resilient without changing its …
…logic" This reverts commit ec8fb81.
Configuration menu - View commit details
-
Copy full SHA for 0c14fea - Browse repository at this point
Copy the full SHA 0c14feaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63764bf - Browse repository at this point
Copy the full SHA 63764bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2a6827 - Browse repository at this point
Copy the full SHA b2a6827View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8707d26 - Browse repository at this point
Copy the full SHA 8707d26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50499e1 - Browse repository at this point
Copy the full SHA 50499e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f56b62a - Browse repository at this point
Copy the full SHA f56b62aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92e1249 - Browse repository at this point
Copy the full SHA 92e1249View commit details -
test: skipping tests checking that the original
http.{get,request}
……methods are called in case a request is not intercepted
Configuration menu - View commit details
-
Copy full SHA for 7d0ee09 - Browse repository at this point
Copy the full SHA 7d0ee09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78acbb3 - Browse repository at this point
Copy the full SHA 78acbb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 035e451 - Browse repository at this point
Copy the full SHA 035e451View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0b939f - Browse repository at this point
Copy the full SHA a0b939fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cab4132 - Browse repository at this point
Copy the full SHA cab4132View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbb2af6 - Browse repository at this point
Copy the full SHA dbb2af6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c42a9fb - Browse repository at this point
Copy the full SHA c42a9fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c611d18 - Browse repository at this point
Copy the full SHA c611d18View commit details -
test: adapt error message when overwritten
new http.ClientRequest()
…… is called without options
Configuration menu - View commit details
-
Copy full SHA for 191204e - Browse repository at this point
Copy the full SHA 191204eView commit details -
test: adapt test for internal
normalizeRequestOptions()
method. We ……no longer use a `.proto` property
Configuration menu - View commit details
-
Copy full SHA for 3662d9e - Browse repository at this point
Copy the full SHA 3662d9eView commit details -
test: adapt test for internal
stringifyRequest()
method. We no long……er use a `.proto` property
Configuration menu - View commit details
-
Copy full SHA for a9fd400 - Browse repository at this point
Copy the full SHA a9fd400View commit details -
Configuration menu - View commit details
-
Copy full SHA for 108195c - Browse repository at this point
Copy the full SHA 108195cView commit details -
test:
nock.removeInterceptor()
no longer acceptsproto
option. Ex……pects `protocol` instead BREAKING CHANGE: `nock.removeInterceptor()` no longer accepts `proto` option. The option is `protocol` now and must be set to either `http:` or `https:`. Before ```js nock.removeInterceptor({ proto: "https", hostname: "example.test", path: "/somepath", }); ``` After ```js nock.removeInterceptor({ protocol: "https:", hostname: "example.test", path: "/somepath", }); ```
Configuration menu - View commit details
-
Copy full SHA for 793ad1f - Browse repository at this point
Copy the full SHA 793ad1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6f13de - Browse repository at this point
Copy the full SHA a6f13deView commit details -
Configuration menu - View commit details
-
Copy full SHA for c340aa0 - Browse repository at this point
Copy the full SHA c340aa0View commit details -
Revert "test: remove usage of fake timers where it is not needed"
This reverts commit dbb2af6.
Configuration menu - View commit details
-
Copy full SHA for e32b498 - Browse repository at this point
Copy the full SHA e32b498View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc5e3dc - Browse repository at this point
Copy the full SHA cc5e3dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a5590c - Browse repository at this point
Copy the full SHA 3a5590cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1a0f3c - Browse repository at this point
Copy the full SHA e1a0f3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17ac6b1 - Browse repository at this point
Copy the full SHA 17ac6b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51f7332 - Browse repository at this point
Copy the full SHA 51f7332View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b87e6f - Browse repository at this point
Copy the full SHA 7b87e6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8443aea - Browse repository at this point
Copy the full SHA 8443aeaView commit details -
test: should be safe to call in the middle of a request
see breaking change about intercept logic location
Configuration menu - View commit details
-
Copy full SHA for 70fc395 - Browse repository at this point
Copy the full SHA 70fc395View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f912fb - Browse repository at this point
Copy the full SHA 0f912fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ef1407 - Browse repository at this point
Copy the full SHA 3ef1407View commit details -
Configuration menu - View commit details
-
Copy full SHA for 522fa27 - Browse repository at this point
Copy the full SHA 522fa27View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3f66e9 - Browse repository at this point
Copy the full SHA b3f66e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd4eaab - Browse repository at this point
Copy the full SHA bd4eaabView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd926b8 - Browse repository at this point
Copy the full SHA fd926b8View commit details
Commits on Dec 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6c8d591 - Browse repository at this point
Copy the full SHA 6c8d591View commit details -
Configuration menu - View commit details
-
Copy full SHA for 437b431 - Browse repository at this point
Copy the full SHA 437b431View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1f68cc - Browse repository at this point
Copy the full SHA b1f68ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4db4099 - Browse repository at this point
Copy the full SHA 4db4099View commit details -
Configuration menu - View commit details
-
Copy full SHA for fac8952 - Browse repository at this point
Copy the full SHA fac8952View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8e6cca - Browse repository at this point
Copy the full SHA d8e6ccaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5f8ede - Browse repository at this point
Copy the full SHA f5f8edeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9b7a85 - Browse repository at this point
Copy the full SHA d9b7a85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4535a01 - Browse repository at this point
Copy the full SHA 4535a01View commit details -
fix: when bypassing the intercept and sending the real request instea…
…d, call `.write` and `.end` on next tick and emit custom `nock-data` and `nock-end` events to enable recording of the request body
Configuration menu - View commit details
-
Copy full SHA for 0abe3bf - Browse repository at this point
Copy the full SHA 0abe3bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86c4a37 - Browse repository at this point
Copy the full SHA 86c4a37View commit details
Commits on Dec 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6f3bbd6 - Browse repository at this point
Copy the full SHA 6f3bbd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96d0c2a - Browse repository at this point
Copy the full SHA 96d0c2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f77a9c - Browse repository at this point
Copy the full SHA 7f77a9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a65e34 - Browse repository at this point
Copy the full SHA 3a65e34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72fc5f3 - Browse repository at this point
Copy the full SHA 72fc5f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6366906 - Browse repository at this point
Copy the full SHA 6366906View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9367db - Browse repository at this point
Copy the full SHA f9367dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea2c986 - Browse repository at this point
Copy the full SHA ea2c986View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d4f57a - Browse repository at this point
Copy the full SHA 8d4f57aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b04e6b6 - Browse repository at this point
Copy the full SHA b04e6b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58d8754 - Browse repository at this point
Copy the full SHA 58d8754View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0b56fb - Browse repository at this point
Copy the full SHA f0b56fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9355665 - Browse repository at this point
Copy the full SHA 9355665View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cb849d - Browse repository at this point
Copy the full SHA 9cb849dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1320fee - Browse repository at this point
Copy the full SHA 1320feeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92dab98 - Browse repository at this point
Copy the full SHA 92dab98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81cb9e6 - Browse repository at this point
Copy the full SHA 81cb9e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae99575 - Browse repository at this point
Copy the full SHA ae99575View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c0df4c - Browse repository at this point
Copy the full SHA 0c0df4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 866e2e0 - Browse repository at this point
Copy the full SHA 866e2e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e3df37 - Browse repository at this point
Copy the full SHA 3e3df37View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf08676 - Browse repository at this point
Copy the full SHA bf08676View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6834394 - Browse repository at this point
Copy the full SHA 6834394View commit details
Commits on Dec 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 64fe949 - Browse repository at this point
Copy the full SHA 64fe949View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec44b74 - Browse repository at this point
Copy the full SHA ec44b74View commit details