Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert #2497 (nock.removeInterceptor can remove the wrong Intercept) #2510

Closed
wants to merge 1 commit into from
Closed

fix: revert #2497 (nock.removeInterceptor can remove the wrong Intercept) #2510

wants to merge 1 commit into from

Conversation

gr2m
Copy link
Member

@gr2m gr2m commented Aug 16, 2023

This reverts commit 92de0de. See #2500

@mikicho
Copy link
Contributor

mikicho commented Aug 16, 2023 •
edited

@gr2m I think you need to revert the other commit to fix #2500
removeInterceptor is workyas expected , please don't merge this.

@gr2m
Copy link
Member Author

gr2m commented Aug 16, 2023

Ha! Thank you!

@gr2m gr2m closed this Aug 16, 2023
@gr2m gr2m deleted the revert-v13.3.2 branch August 16, 2023 20:57
@gr2m
Copy link
Member Author

gr2m commented Aug 16, 2023

there we go: #2511

@MaxMood96 MaxMood96 mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gr2m @mikicho