Update #158 fix for request module and strict SSL #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 48e8be5 added a compatibility fix for users of the request NPM module and strict SSL cert checking. The request module has since been updated (see request/request#1615 for more details), and a corresponding change should be made in nock to ensure compatibility.
pgte
added a commit
that referenced
this pull request
Dec 23, 2015
Update #158 fix for request module and strict SSL
|
@jeffomatic thanks! Landed on v3.6.0. |
|
Thanks for the super-quick review/merge! On Wed, Dec 23, 2015 at 4:01 AM, Pedro Teixeira notifications@github.com
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 48e8be5 added a compatibility fix for users of the request
NPM module and strict SSL cert checking. The request module has
since been updated (see request/request#1615
for more details), and a corresponding change should be made in
nock to ensure compatibility.