Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split sql collection #3650

Merged
merged 25 commits into from May 17, 2024
Merged

chore: split sql collection #3650

merged 25 commits into from May 17, 2024

Conversation

chareice
Copy link
Contributor

@chareice chareice commented Mar 7, 2024

fix T-2457, T-4235

Copy link

height bot commented Mar 7, 2024

This pull request has been linked to and will mark 3 tasks as "Done" when merged:

  • T-2457 sql collection 的插件化(后端) (unlink task)
  • T-4236 删除sql表会删除数据库相同标识的物理表;sql表Configure fields 的时候 ,删除字段 ,删除最后一个字段也会把数据库的物理表删除 (unlink task)
  • T-4235 创建sql表,如果未查询出数据,字段列表不出现 (unlink task)

@chenos chenos requested a review from Xilesun April 3, 2024 03:31
Copy link
Contributor

@Xilesun Xilesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20240413135105_rec_

sqlCollection:execute 404

@Xilesun Xilesun self-requested a review May 14, 2024 13:01
Xilesun
Xilesun previously approved these changes May 14, 2024
@Xilesun Xilesun dismissed their stale review May 14, 2024 13:02

I take over this pull request

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

Tests results for "E2E"

15 flaky ⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/continueWhenYesFormulaEngine.test.ts:30:5 › Collection event Add Data Trigger, Formula engine, determines that the trigger node single line text field variable is equal to an equal constant, passes.
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/continueWhenYesFormulaEngine.test.ts:690:5 › Collection event add data trigger, Formula engine, determine the trigger node integer variable is not equal to the query node not equal integer variable, pass.
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/BranchIntoYesAndNoMathEngine.test.ts:375:5 › Collection event add data trigger, determines that the trigger node integer field variable is not equal to an unequal constant, passes.
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/__e2e__/schemaInitializer.test.ts:23:7 › where grid card block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/association.test.ts:245:5 › association block action permission
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers › TableActionInitializers should add bulk update
⚠️ [chromium] › plugins/@nocobase/plugin-gantt/src/client/__e2e__/schemaInitailizer.test.ts:13:5 › BlockInitializers should add gantt block
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaSettings.test.ts:14:7 › data will be updated && Assign field values && after successful submission › data will be updated && Assign field values && after successful submission
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-calendar/src/client/__e2e__/schemaInitializer.test.ts:14:7 › where can be added › page
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings.test.ts:397:9 › actions schema settings › update record › Assign field values
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings1.test.ts:92:9 › table block schema settings › enable drag and drop sorting › enable drag and drop sorting
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers should add bulk edit action › bulk edit in TableActionInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-manual/src/client/__e2e__/createRecordForm5.test.ts:28:7 › field data entry › Collection event to add a data trigger, entering mailbox data

547 passed, 24 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

@Xilesun Xilesun merged commit 3d000d3 into main May 17, 2024
21 of 22 checks passed
@Xilesun Xilesun deleted the T-2457 branch May 17, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants