Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug: UI/UX fixes #7156

Closed
13 tasks done
dstala opened this issue Dec 5, 2023 · 10 comments 路 Fixed by #7173
Closed
13 tasks done

馃悰 Bug: UI/UX fixes #7156

dstala opened this issue Dec 5, 2023 · 10 comments 路 Fixed by #7173
Assignees
Milestone

Comments

@dstala
Copy link
Member

dstala commented Dec 5, 2023

Please confirm if bug report does NOT exists already ?

  • I confirm there is no existing issue for this

Steps to reproduce ?

  • Group-by initial menu to be made similar to Sort
    Screenshot 2023-12-05 at 2 40 12 PM
    Screenshot 2023-12-05 at 2 40 24 PM

  • Update Group-by testcases

  • DateTime field, on the picker - set default time to current time always & enable OK button by default

  • Default name for token, let it be Token-1 Token-2 Token-3 and such
    Screenshot 2023-12-06 at 12 35 13 PM

  • Webhook modal

    • Default name, let it be Webhook-1 Webhook-2 and such
    • Set first option in the trigger list as selected by default
      Screenshot 2023-12-06 at 12 37 52 PM
  • Created-at, Updated-at : right click should disable Clear option;

  • Introduce paste option in cell right click context menu

  • System column shouldn't be editable

  • Junction table shouldn't be editable
    Screenshot 2023-12-06 at 4 06 35 PM
    Screenshot 2023-12-06 at 4 06 51 PM

  • Minimum width for select drop down's
    Screenshot 2023-12-07 at 9 57 09 PM

Desired Behavior

x

Project Details

202.9

Attachments

No response

@gauravruhela07
Copy link

Hey, just getting started with making contributions. I would like to work on it, can you please assign this issue to me? Thank you.

@rameshmane7218
Copy link
Collaborator

Hi @gauravruhela07, I have already started working on this issue. You can find another issue.

Thanks for showing interest in contributing to NocoDB!

@rameshmane7218
Copy link
Collaborator

@dstala is their any specific min width for select drop down's ?

@rameshmane7218
Copy link
Collaborator

@dstala I'm setting min-width = max-content

@dstala
Copy link
Member Author

dstala commented Dec 10, 2023

@dstala I'm setting min-width = max-content

Let us use fixed width; IMO, we can have width equal to default field width on grid

@rameshmane7218
Copy link
Collaborator

@dstala I'm setting min-width = max-content

Let us use fixed width; IMO, we can have width equal to default field width on grid

And what about option max line, text should wrap to next line or text should be hidden (this is current)
Screenshot 2023-12-11 at 11 09 33鈥疉M

@dstala
Copy link
Member Author

dstala commented Dec 12, 2023

  • Open token page, error noticed

Noticed with PG Root DB

[Nest] 46679  - 12/12/2023, 12:41:53鈥疨M   ERROR [GlobalExceptionFilter] select "nc_api_tokens"."id", "nc_api_tokens"."token", "nc_api_tokens"."description", "nc_api_tokens"."fk_user_id", "nc_api_tokens"."base_id", "nc_api_tokens"."created_at", "nc_api_tokens"."updated_at", (select "email" from "nc_users_v2" where nc_users_v2.id = nc_api_tokens.fk_user_id) as "created_by" from "nc_api_tokens" limit $1 - LIMIT must not be negative
error: select "nc_api_tokens"."id", "nc_api_tokens"."token", "nc_api_tokens"."description", "nc_api_tokens"."fk_user_id", "nc_api_tokens"."base_id", "nc_api_tokens"."created_at", "nc_api_tokens"."updated_at", (select "email" from "nc_users_v2" where nc_users_v2.id = nc_api_tokens.fk_user_id) as "created_by" from "nc_api_tokens" limit $1 - LIMIT must not be negative
    at Parser.parseErrorMessage (/Users/rajuudava/NocoDB/nocodb/node_modules/.pnpm/pg-protocol@1.6.0/node_modules/pg-protocol/src/parser.ts:369:69)
    at Parser.handlePacket (/Users/rajuudava/NocoDB/nocodb/node_modules/.pnpm/pg-protocol@1.6.0/node_modules/pg-protocol/src/parser.ts:188:21)
    at Parser.parse (/Users/rajuudava/NocoDB/nocodb/node_modules/.pnpm/pg-protocol@1.6.0/node_modules/pg-protocol/src/parser.ts:103:30)
    at Socket.<anonymous> (/Users/rajuudava/NocoDB/nocodb/node_modules/.pnpm/pg-protocol@1.6.0/node_modules/pg-protocol/src/index.ts:7:48)
    at Socket.emit (node:events:513:28)
    at Socket.emit (node:domain:489:12)
    at addChunk (node:internal/streams/readable:324:12)
    at readableAddChunk (node:internal/streams/readable:297:9)
    at Socket.Readable.push (node:internal/streams/readable:234:10)
    at TCP.onStreamRead (node:internal/stream_base_commons:190:23)

@dstala
Copy link
Member Author

dstala commented Dec 12, 2023

@dstala I'm setting min-width = max-content

Let us use fixed width; IMO, we can have width equal to default field width on grid

And what about option max line, text should wrap to next line or text should be hidden (this is current) Screenshot 2023-12-11 at 11 09 33鈥疉M

Use ... & show full text on hover in a tooltip

@rameshmane7218
Copy link
Collaborator

@dstala I'm setting min-width = max-content

Let us use fixed width; IMO, we can have width equal to default field width on grid

And what about option max line, text should wrap to next line or text should be hidden (this is current) Screenshot 2023-12-11 at 11 09 33鈥疉M

Use ... & show full text on hover in a tooltip

  • Added tooltip for this and the max width of option is fixed to 20 char width even if select dropdown width is greater than 20 char width

@rameshmane7218
Copy link
Collaborator

@dstala I'm setting min-width = max-content

Let us use fixed width; IMO, we can have width equal to default field width on grid

And what about option max line, text should wrap to next line or text should be hidden (this is current) Screenshot 2023-12-11 at 11 09 33鈥疉M

Use ... & show full text on hover in a tooltip

  • Added tooltip for this and the max width of option is fixed to 20 char width even if select dropdown width is greater than 20 char width

Reverted back as this changes leads to fail playwright test cases where we did getOptionByText()

dstala added a commit that referenced this issue Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants