fix: UI/UX fixes #7156 #7173
Merged
fix: UI/UX fixes #7156 #7173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
wingkwong
requested changes
Dec 6, 2023
packages/nc-gui/components/smartsheet/toolbar/CreateGroupBy.vue
Outdated
Show resolved
Hide resolved
packages/nc-gui/components/smartsheet/toolbar/CreateGroupBy.vue
Outdated
Show resolved
Hide resolved
packages/nc-gui/components/smartsheet/toolbar/CreateGroupBy.vue
Outdated
Show resolved
Hide resolved
wingkwong
requested changes
Dec 8, 2023
wingkwong
requested changes
Dec 8, 2023
Comment on lines
135
to
137
| if (!modelValue) { | ||
| localState.value = dayjs(new Date()) | ||
| } |
There was a problem hiding this comment.
as discussed with Raju, the behaviour is a bit off. When I open the datetime picker, the current datetime is expected to be selected. However, we only save the value once we click OK, which means the value shouldn't be saved if I un-focus it. Currently the value will be saved anyway.
There was a problem hiding this comment.
Okay, first I tried to set :default-picker-value="dayjs(new Date())" but this is not woking.
I will check this
There was a problem hiding this comment.
I fixed this.
Now GroupByMenu test is failing that I need to fix as I changed the GroupByMenu UI and now it's similar to SortMenu
In this PR |
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
…ing the col object Signed-off-by: Pranav C <pranavxc@gmail.com>
…ing the col object Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
dstala
approved these changes
Dec 12, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Change type
rolePermissionsinlib/types.tsfile is imported from wrong file./constantsinsted of./aclTest/ Verification
Provide summary of changes.