Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support yyyy-mm in Datepicker #6870

Merged
merged 31 commits into from
Dec 7, 2023
Merged

feat: support yyyy-mm in Datepicker #6870

merged 31 commits into from
Dec 7, 2023

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Nov 3, 2023

Change Summary

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@dstala dstala marked this pull request as ready for review November 7, 2023 15:02
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Uffizzi Preview deployment-40857 was deleted.

@wingkwong wingkwong added the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Nov 17, 2023
@dstala
Copy link
Member

dstala commented Nov 17, 2023

@wingkwong IMO, we can skip this new format for dateTime & just have it for Date type.
& if we support YEAR() and MONTH() as formula's, this format could become redundant.

@wingkwong wingkwong marked this pull request as draft November 18, 2023 04:55
@wingkwong
Copy link
Member Author

@wingkwong IMO, we can skip this new format for dateTime & just have it for Date type. & if we support YEAR() and MONTH() as formula's, this format could become redundant.

I plan to just have it for Date only. For DateTime, YYYY-MM HH:MM:SS seems not make any sense. Will update the code later.

@wingkwong wingkwong added the trigger-CI force trigger CI even if PR in draft mode label Nov 27, 2023
@wingkwong wingkwong removed 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. trigger-CI force trigger CI even if PR in draft mode labels Nov 28, 2023
@wingkwong wingkwong marked this pull request as ready for review November 28, 2023 17:44
@dstala
Copy link
Member

dstala commented Dec 2, 2023

  • the following combination when tried over SQLite root DB results in invalid date
    image

Copy link
Member

@dstala dstala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstala dstala merged commit 73e3350 into develop Dec 7, 2023
22 checks passed
@dstala dstala deleted the feat/yyyy-mm branch December 7, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔦 Feature: columnType Date Format : add YYYY-MM
3 participants