Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : added tooltip for column fields #7114

Merged
merged 23 commits into from
Dec 1, 2023
Merged

fix : added tooltip for column fields #7114

merged 23 commits into from
Dec 1, 2023

Conversation

musharaf-nocodb
Copy link
Contributor

@musharaf-nocodb musharaf-nocodb commented Nov 29, 2023 •
edited

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

https://www.loom.com/share/675e1c52230d4a0fbd0b03bc84770d4c?sid=3f33b8ae-6863-4219-90cb-d43ab09d6bff

image

Added ToolTip in below sections

  • Column fields in View Row Section
  • Filters Column Fields
  • Sidebar Tables and Views names
  • Topbar Views names
  • Child table names
  • Fixed width in ERD column Fields
  • Sort Fields
  • UI-ACL header and cell Values

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023 •
edited

Uffizzi Preview deployment-41726 was deleted.

@dstala
Copy link
Member

dstala commented Nov 29, 2023 •
edited by musharaf-nocodb

  • To fix
    Screenshot 2023-11-29 at 9 27 35 PM

  • Needs fix in below highlighted areas
    Screenshot 2023-11-29 at 9 11 55 PM

  • In toolbar filter, group-by, sort menu :: let us limit width, show ... by default & show full name as tooltip on hover
    Screenshot 2023-11-29 at 9 15 14 PM

  • Needs fix in details tab

    • display field should be truncated
    • rest of the fields are truncated, but doesn't display full name on hover

Screenshot 2023-11-29 at 9 16 06 PM

  • ERD, truncate

Screenshot 2023-11-29 at 9 17 55 PM

@mustafapc19
Copy link
Contributor

Expanded form used to have left and right padding which seems to be removed. Intentional?
New UI:
image
Old UI:
image

@wingkwong wingkwong self-requested a review November 30, 2023 09:31
wingkwong
wingkwong reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@wingkwong wingkwong left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever you apply classes in NcTooltip, the classes are duplicated.

image

@mustafapc19
Copy link
Contributor

@wingkwong That is known issue with NcTooltip. I'll fix in another PR 👍

wingkwong
wingkwong reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tooltip text in formula. Probably other virtual fields too.

image

@musharaf-nocodb
Copy link
Contributor Author

Missing tooltip text in formula. Probably other virtual fields too.

image

Fixed in below commit

fix : fixed tooltip for virtual cell
e84c468

@musharaf-nocodb
Copy link
Contributor Author

Expanded form used to have left and right padding which seems to be removed. Intentional? New UI: image Old UI: image

Fixed in below commit

fix : fixed tooltip for virtual cell
e84c468

@dstala dstala merged commit c79212d into develop Dec 1, 2023
19 of 20 checks passed
@dstala dstala deleted the fix/fields-hover-effects branch December 1, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustafapc19 mustafapc19 mustafapc19 left review comments

@wingkwong wingkwong wingkwong left review comments

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@musharaf-nocodb @CLAassistant @dstala @mustafapc19 @wingkwong