Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: formula expansion as md sections #7116

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Conversation

dstala
Copy link
Member

@dstala dstala commented Nov 29, 2023

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Suggest to use title case for the title. e.g. Conditional expressions -> Conditional Expressions
  2. Heading of Related Articles is not aligned across these files. Numeric & String are using ### while Date & Conditional Expressions are using ##. With ###, it won't show in the sidebar.
  3. For Conditional Expressions, it doesn't include This cheat sheet ....

Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@dstala
Copy link
Member Author

dstala commented Dec 1, 2023

  1. Suggest to use title case for the title. e.g. Conditional expressions -> Conditional Expressions
  2. Heading of Related Articles is not aligned across these files. Numeric & String are using ### while Date & Conditional Expressions are using ##. With ###, it won't show in the sidebar.
  3. For Conditional Expressions, it doesn't include This cheat sheet ....

You have a big eye for details! Taken care!

@dstala dstala merged commit be6398b into develop Dec 1, 2023
1 check passed
@dstala dstala deleted the docs/formula-details branch December 1, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants