Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display as progress #7138

Merged
merged 3 commits into from
Dec 5, 2023
Merged

feat: display as progress #7138

merged 3 commits into from
Dec 5, 2023

Conversation

mertmit
Copy link
Member

@mertmit mertmit commented Dec 1, 2023

Change Summary

closes #6973
image
image

Change type

  • feat: (new feature for the user, not a new feature for build script)

@mertmit mertmit requested a review from dstala December 1, 2023 14:11
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023 •
edited

Uffizzi Preview deployment-41965 was deleted.

wingkwong
wingkwong reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress is not shown in expanded form. Is it by design?

image

@dstala
Copy link
Member

dstala commented Dec 2, 2023 •
edited by mertmit

  • [wkw] expanded form, progress isn't shown
  • [raju] remove check-mark for 100% +; display percent value as is (can be negative as well; truncate to 2 decimal places by default)
  • [shreyas] colors- brand/500, green/500

@mertmit
Copy link
Member Author

mertmit commented Dec 2, 2023

@wingkwong this wasn't intentional, on expanded form we pass editEnabled true to all cells, and progress is only visible while edit is not enabled, I will try to find a workaround.

@mertmit mertmit requested a review from dstala December 2, 2023 09:12
@mertmit
feat: display as progress
c70ae51 
Signed-off-by: mertmit <mertmit99@gmail.com>
@mertmit
fix: PR requested changes
a7dc9bd 
Signed-off-by: mertmit <mertmit99@gmail.com>
@mertmit
fix: add test selector to wrapper
5a3f7f1 
Signed-off-by: mertmit <mertmit99@gmail.com>
@mertmit mertmit merged commit d541377 into develop Dec 5, 2023
22 checks passed
@mertmit mertmit deleted the feat/progress branch December 5, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingkwong wingkwong wingkwong left review comments

@dstala dstala Awaiting requested review from dstala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔦 Feature: display as progress bar for percent
3 participants
@mertmit @dstala @wingkwong