Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dropdown UI #7181

Merged
merged 55 commits into from
Dec 12, 2023
Merged

Fix/dropdown UI #7181

merged 55 commits into from
Dec 12, 2023

Conversation

musharaf-nocodb
Copy link
Contributor

@musharaf-nocodb musharaf-nocodb commented Dec 7, 2023

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

hover effect in dropdown's is not consistent. some of the places that need correction are

  • filter
Screenshot 2023-12-07 at 2 21 15 PM
  • sort
  • group-by
  • row height
  • field context menu
  • add/edit modal, fields drop down
Screenshot 2023-12-07 at 5 52 41 PM
  • i18n language menu (OSS)
Screenshot 2023-12-11 at 8 23 49 AM Screenshot 2023-12-11 at 8 25 37 AM
  • global search modal
Screenshot 2023-12-08 at 10 19 54 AM
  • webhook dropdown (event, url, action, headers, etc)
  • API sub-type modal
Screenshot 2023-12-07 at 4 42 32 PM
  • Team & Settings, User management (invite user, role drop down) (OSS)
Screenshot 2023-12-07 at 2 15 53 PM Screenshot 2023-12-07 at 2 18 05 PM
  • Data source (database type, ssl mode, inflection menu)
  • new record

Additional information / screenshots (optional)

Desired Behavior

grey background with rounded rectangle + edge padding

Anything for maintainers to be made aware of

@musharaf-nocodb musharaf-nocodb marked this pull request as ready for review December 8, 2023 06:56
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Uffizzi Preview deployment-42533 was deleted.

@dstala
Copy link
Member

dstala commented Dec 8, 2023

Screenshot 2023-12-08 at 2 09 18 PM

  • Current selected option when a drop down opens : highlight in blue as in case of language.
    • Collaborative mode / Locked mode
    • Fields add / edit modal
    • Global search
    • Record height
    • Details tab, APIs, sub option
    • New data source modal - multiple fields

@dstala
Copy link
Member

dstala commented Dec 11, 2023

  • date field, retain order of configuration options as before
    Screenshot 2023-12-11 at 1 35 28 PM
  • field add modal, option to add JSON not accessible
    Screenshot 2023-12-11 at 1 30 43 PM

Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run pnpm run lint on both nc-gui and nocodb

packages/nc-gui/components/nc/SelectOption.vue Outdated Show resolved Hide resolved
packages/nc-gui/components/nc/SelectOption.vue Outdated Show resolved Hide resolved
packages/nc-gui/components/nc/SelectOption.vue Outdated Show resolved Hide resolved
packages/nc-gui/assets/style.scss Outdated Show resolved Hide resolved
packages/nc-gui/assets/style.scss Outdated Show resolved Hide resolved
packages/nc-gui/assets/style.scss Outdated Show resolved Hide resolved
@dstala dstala merged commit 7d7267a into develop Dec 12, 2023
22 checks passed
@dstala dstala deleted the fix/dropdown-ui branch December 12, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants