Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cache del and update #7727

Merged
merged 11 commits into from
Feb 27, 2024
Merged

fix: cache del and update #7727

merged 11 commits into from
Feb 27, 2024

Conversation

mertmit
Copy link
Member

@mertmit mertmit commented Feb 26, 2024 •
edited

Change Summary

  • Avoid calling del on object update (breaks cache meta)
  • Added NocoCache.update for repetitive logic
  • Move cache update logic after meta update

Change type

  • fix: (bug fix for the user, not a fix to a build script)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited

Uffizzi Preview deployment-47273 was deleted.

@o1lab o1lab force-pushed the nc-fix/cache-del branch 2 times, most recently from 91b659e to 09f5314 Compare February 27, 2024 09:28
@dstala dstala merged commit 67d2820 into develop Feb 27, 2024
22 checks passed
@dstala dstala deleted the nc-fix/cache-del branch February 27, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mertmit @dstala