Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple relative directory paths separated by path.delimiter to work #661

Merged
merged 2 commits into from
Jan 15, 2022
Merged

Allow multiple relative directory paths separated by path.delimiter to work #661

merged 2 commits into from
Jan 15, 2022
+77 −3

Conversation

inside
Copy link
Contributor

@inside inside commented Oct 8, 2021 •
edited

  • Add tests for the multiple configurations feature
  • transform each relative config dir to an absolute path

fix: #660

@inside
Add tests for the multiple configurations feature
0767cba 
This feature is documented here:
https://github.com/lorenwest/node-config/wiki/Environment-Variables#node_config_dir

Relative or absolute paths separated by `path.delimiter` as a value for
`process.env.NODE_CONFIG_DIR` should work.
@inside
transform each relative config dir to an absolute path
b6dc7ca 
fix: node-config#660
@inside inside changed the title master Allow multiple relative directory paths separated by path.delimiter to work Oct 8, 2021
@inside inside mentioned this pull request Oct 8, 2021
Closed
markstos
markstos reviewed Oct 12, 2021
View reviewed changes
Copy link
Collaborator

@markstos markstos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR with test. See the one question I have about resolving paths.

lib/config.js Show resolved Hide resolved
@markstos markstos merged commit cfde385 into node-config:master Jan 15, 2022
@lorenwest lorenwest mentioned this pull request Nov 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstos markstos markstos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NODE_CONFIG_DIR multiple relative directory paths separated by path.delimiter throws an error
2 participants
@inside @markstos