fix(vulnerability): upgrade json5 version from 2.2.1 to 2.2.2 #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it will be easier if the version is 2.2.x ? |
|
I don't agree that the PR that was filed in JSON5 to address this CVE actually addresses the problem. Can someone take another peek at their PR? https://github.com/json5/json5/pull/296/files This seems to be asserting the bug, not fixing it: |
jdmarshall
reviewed
Jan 6, 2023
|
Hi all, |
|
Reading: it seems the problem is solved (in json I'm curious... why are we thinking this PR should not be accepted? |
|
it has been 2 weeks, maybe bump it to 2.2.3 now ? |
|
Published as v3.3.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json5 dependency is vulnerable in the current version which is
2.2.1, this PR contains the fix. The vulnerability is resolved in version2.2.2.This PR resolves the issue #712