Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace var to let and const #720

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

jamashita
Copy link
Contributor

Hi there! I love this package so much!
I think I can help to improve this package by sending some PRs, at first I think this package can use let and const instead of var!

@markstos markstos merged commit 46d0c31 into node-config:master Feb 28, 2023
renovate bot added a commit to tomacheese/cmcutter that referenced this pull request Jan 9, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [config](http://github.com/node-config/node-config.git)
([source](https://togithub.com/node-config/node-config)) | [`3.3.9` ->
`3.3.10`](https://renovatebot.com/diffs/npm/config/3.3.9/3.3.10) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/config/3.3.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/config/3.3.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/config/3.3.9/3.3.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/config/3.3.9/3.3.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>node-config/node-config (config)</summary>

###
[`v3.3.10`](https://togithub.com/node-config/node-config/releases/tag/v3.3.10)

[Compare
Source](https://togithub.com/node-config/node-config/compare/v3.3.9...v3.3.10)

##### What's Changed

- replace var to let and const by
[@&#8203;jamashita](https://togithub.com/jamashita) in
[node-config/node-config#720
- refactor: 💡 xxx === undefined => typeof xxx === 'undefined' by
[@&#8203;jamashita](https://togithub.com/jamashita) in
[node-config/node-config#729
- Fix source maps when using ts config files, improve performance
loading ts config files by
[@&#8203;andrzej-woof](https://togithub.com/andrzej-woof) in
[node-config/node-config#721
- fix: lack of comments removal, invalid regexp by
[@&#8203;DeutscherDude](https://togithub.com/DeutscherDude) in
[node-config/node-config#745

##### New Contributors

- [@&#8203;jamashita](https://togithub.com/jamashita) made their first
contribution in
[node-config/node-config#720
- [@&#8203;andrzej-woof](https://togithub.com/andrzej-woof) made their
first contribution in
[node-config/node-config#721
- [@&#8203;DeutscherDude](https://togithub.com/DeutscherDude) made their
first contribution in
[node-config/node-config#745

**Full Changelog**:
node-config/node-config@v3.3.9...v3.3.10

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/cmcutter).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants