Fix source maps when using ts config files, improve performance loading ts config files #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
andrzej-woof
changed the title
|
@flodaniel does this TypeScript file look right to you? |
|
I'm willing to get to try this. If we get more bug reports after the next release, we'll have to revert. |
This was referenced Aug 4, 2023
renovate bot
added a commit
to tomacheese/cmcutter
that referenced
this pull request
Jan 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [config](http://github.com/node-config/node-config.git) ([source](https://togithub.com/node-config/node-config)) | [`3.3.9` -> `3.3.10`](https://renovatebot.com/diffs/npm/config/3.3.9/3.3.10) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>node-config/node-config (config)</summary> ### [`v3.3.10`](https://togithub.com/node-config/node-config/releases/tag/v3.3.10) [Compare Source](https://togithub.com/node-config/node-config/compare/v3.3.9...v3.3.10) ##### What's Changed - replace var to let and const by [@​jamashita](https://togithub.com/jamashita) in [node-config/node-config#720 - refactor: 💡 xxx === undefined => typeof xxx === 'undefined' by [@​jamashita](https://togithub.com/jamashita) in [node-config/node-config#729 - Fix source maps when using ts config files, improve performance loading ts config files by [@​andrzej-woof](https://togithub.com/andrzej-woof) in [node-config/node-config#721 - fix: lack of comments removal, invalid regexp by [@​DeutscherDude](https://togithub.com/DeutscherDude) in [node-config/node-config#745 ##### New Contributors - [@​jamashita](https://togithub.com/jamashita) made their first contribution in [node-config/node-config#720 - [@​andrzej-woof](https://togithub.com/andrzej-woof) made their first contribution in [node-config/node-config#721 - [@​DeutscherDude](https://togithub.com/DeutscherDude) made their first contribution in [node-config/node-config#745 **Full Changelog**: node-config/node-config@v3.3.9...v3.3.10 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/cmcutter). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #530 and #613
The problem was that newly registered
ts-nodetook over transpilation of all files.Using
ignoreoption we can exclude transpiling again anything that is not a typescript file.First regex
(?:^|/)node_modules/is just the default that is used byts-nodeto excludenode_modulesifignoreoption is unspecified.