fix: lack of comments removal, invalid regexp

[DeutscherDude]

This addresses issues mentioned in #715
The issue mentioned in #704 will be investigated further

[DeutscherDude]

Hello @lorenwest,
I have amended the parsing of JSON to utilize JSON5 parser as per this thread.
Additionally, I removed the extraneous stripping of comments from CSON parser.
There are some changes introduced to stripComments, i.e. a new RegExp, which I amended, so that it does not use the [a-zA-z] honey pot.
Happy to introduce any further required changes 😄

*Edit: Though the removal of comment stripping from CSON might be a mistake. Let me know your thoughts

[timturnerwhcc]

@lorenwest @DeutscherDude There hasn't been much movement on this PR in a bit - it would be really helpful to have as my team is migrating to Node20.

I'm happy to give feedback on this PR or whatever else to help move it forward.

[jfberry]

We are also holding off a node-20+ migration because of this bug

[lorenwest]

This looks like a healthy change, and I wish it were as simple as approving and merging. Unfortunately for health reasons I've been less than active in this project, and it seems that 2 test failures have crept into the master branch.

One of the problems was resolved in this branch, but there's another that needs further research before merging. When did it start failing? Is it a failure of the test or a failure of the baseline code? Does it only fail on one NodeJS version or many? What was the original intent, and is it still relevant? All of this takes time and energy to resolve, and my philosophy is to never merge into master with a single test failure, otherwise the effort everyone has put into these tests are diluted.

@markstos and I are the two authorized to merge into master and push a new release, and we've been doing it for 8-12 years, and neither of us is getting any younger. Would anyone like to start taking the reigns for node-config going forward? It's pretty stable, but does need TLC every now and then.

[jfberry]

I generally agree with your philosophy but it sounds like this pr doesn’t increase the failures that exist, in fact reduces them?
If so it’s a positive step forward.
Besides what is a show stopper for people with particular config files upgrading to newer versions of node.

[lorenwest]

Looks good

[DeutscherDude]

Happy to be of further aid in the future. I got pretty intimate with the code and feel comfortable with it :).
For now, I am rather entangled with finishing my engineering degree, but gimme a month 😊

[lorenwest]

Thanks for the offer @DeutscherDude . For now I've disabled the failing test as I couldn't see how it could ever have worked. Your branch was merged, a new release was created, and npm latest is now at v3.3.10

...and all tests pass in the master branch again. At some point someone should set up a workflow where a new release runs all tests, requiring all to pass, then bumps up the version, checks it in, creates release notes and pushes to npm.

[Shayan1191]

It's very good