New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow URL class object as an argument for fetch() #1696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
CI fails for reasons unrelated to the change, it fails with the same errors on the main branch as well. {
"compilerOptions": {
"lib": ["DOM"]
}
} resolves the issue, however, I'm not sure if that's the correct way to do it. If it was up to me - I'd force-merge this PR and address the
But happy to add the above mentioned fix if that sounds like a good idea? |
Looking forward to having this published on npm, thanks! |
@jimmywarting, I'm not familiar with the release cycle of this library, but I'm still waiting for this to be published in v3, thank you! |
Kind of release a new version every time a PR with the commit |
Ah, I wasn't aware of that... This probably should've been a |
🎉 This PR is included in version 3.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Purpose
Fixes #1261
Changes
Added
URL
tofetch
andRequest
constructorAdditional information
Inspired by: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/a9f480c82b3b356990e5dd574bf2c1ba9c2fdfb5/types/node-fetch/index.d.ts#L213 and https://github.com/microsoft/TypeScript/blob/f43cd0accac3e5033820fd27035731ed88f54938/lib/lib.dom.d.ts#L18281