Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow URL class object as an argument for fetch() #1696

Merged
merged 2 commits into from Jan 9, 2023
Merged

Allow URL class object as an argument for fetch() #1696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c5652f
allow to fetch URL
Maxim-Mazurok Jan 5, 2023
802353c
address comments
Maxim-Mazurok Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions @types/index.d.ts
View file
Open in desktop
Expand Up @@ -147,7 +147,7 @@ export type RequestRedirect = 'error' | 'follow' | 'manual';
export type ReferrerPolicy = '' | 'no-referrer' | 'no-referrer-when-downgrade' | 'same-origin' | 'origin' | 'strict-origin' | 'origin-when-cross-origin' | 'strict-origin-when-cross-origin' | 'unsafe-url';
export type RequestInfo = string | Request;
export class Request extends BodyMixin {
constructor(input: RequestInfo, init?: RequestInit);
constructor(input: RequestInfo | URL, init?: RequestInit);

/**
* Returns a Headers object consisting of the headers associated with request. Note that headers added in the network layer by the user agent will not be accounted for in this object, e.g., the "Host" header.
Expand Down Expand Up @@ -216,4 +216,4 @@ export class AbortError extends Error {
}

export function isRedirect(code: number): boolean;
export default function fetch(url: RequestInfo, init?: RequestInit): Promise<Response>;
export default function fetch(url: RequestInfo | URL, init?: RequestInit): Promise<Response>;
2 changes: 2 additions & 0 deletions @types/index.test-d.ts
View file
Open in desktop
Expand Up @@ -7,6 +7,7 @@ import * as _fetch from '.';

async function run() {
const getResponse = await fetch('https://bigfile.com/test.zip');
await fetch(new URL('https://bigfile.com/test.zip'));
expectType<boolean>(getResponse.ok);
expectType<number>(getResponse.size);
expectType<number>(getResponse.status);
Expand Down Expand Up @@ -36,6 +37,7 @@ async function run() {
// Post
try {
const request = new Request('http://byjka.com/buka');
new Request(new URL('http://byjka.com/buka'));
expectType<string>(request.url);
expectType<Headers>(request.headers);

Expand Down