Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: Make PR template more task oriented #1224

Merged
merged 9 commits into from Nov 8, 2021
Merged
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 19 additions & 14 deletions .github/PULL_REQUEST_TEMPLATE.md
@@ -1,20 +1,25 @@
<!--
Please read and follow these instructions before creating and submitting a pull request:
<!-- Thanks for contributing! -->

- If you're fixing a bug, ensure you add unit tests to prove that it works.
- Before adding a feature, it is best to create an issue explaining it first. It would save you some effort in case we don't consider it should be included in node-fetch.
- If you are reporting a bug, adding failing units tests can be a good idea.
-->
## Purpose
...
jimmywarting marked this conversation as resolved.
Show resolved Hide resolved

**What is the purpose of this pull request?**
## Changes
...
jimmywarting marked this conversation as resolved.
Show resolved Hide resolved

- [ ] Documentation update
- [ ] Bug fix
- [ ] New feature
- [ ] Other, please explain:
## Additional information
...

**What changes did you make? (provide an overview)**

**Which issue (if any) does this pull request address?**
-------------------------------------------------------------------------------------------------
jimmywarting marked this conversation as resolved.
Show resolved Hide resolved

**Is there anything you'd like reviewers to know?**
<!-- Mark what you have done, Remove unnecessary ones. Add new tasks that may fit (like TODO's) -->
jimmywarting marked this conversation as resolved.
Show resolved Hide resolved
- [ ] I prefixed the PR-title with `docs: `, `fix(area): `, `feat(area): ` or `breaking(area): `
jimmywarting marked this conversation as resolved.
Show resolved Hide resolved
- [ ] I updated ./docs/CHANGELOG.md with a link to this PR or Issue
- [ ] I updated ./docs/v3-UPGRADE-GUIDE
- [ ] I updated the README.md
jimmywarting marked this conversation as resolved.
Show resolved Hide resolved
- [ ] I added unit test(s)

-------------------------------------------------------------------------------------------------

<!-- Add a `- fix #_NUMBER_` line for every PR/Issue this PR solves. Don't comma separate them -->
jimmywarting marked this conversation as resolved.
Show resolved Hide resolved
- fix #000