fix: Add catch/reject for invalid redirect URLs #1395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP responses with invalid URLs in the location header field resulted in an uncatchable error. (`TypeError [ERR_INVALID_URL]: Invalid URL`) Real-world example: `Location: http://`
|
This is pretty much the same as #1387 This one also lacks a test for |
|
True @ #1387 – I have no idea how i missed that ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
HTTP responses with invalid URLs in the location header field resulted in an uncatchable exception (
TypeError [ERR_INVALID_URL]: Invalid URL), even in "manual" redirect-handling mode.This patch fixes the issue, invalid redirect targets are now rejected gracefully.
Changes
new URL(…)inrequest_.on('response', …)of src/index.jsAdditional information
Real-world example to reproduce the problem:
Location: http://