Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the default connection close header. #1736

Merged
merged 1 commit into from Jul 25, 2023

Commits on Apr 21, 2023

  1. fix: Remove the default connection close header.

    Instead, we rely on the underlying http implementation in Node.js
    to handle this, as per the documentation at
    https://nodejs.org/api/http.html#new-agentoptions
    
    This fixes node-fetch#1735 and likely replaces node-fetch#1473
    
    The original change introducing this provided no clear motivation
    for the override, and the implementation has since been changed to
    disable this header when an agent is provided, so I think there
    is sufficient evidence that removing this is the correct behaviour.
    node-fetch@af21ae6
    node-fetch@7f68577
    dhedey committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    d49b494 View commit details
    Browse the repository at this point in the history