Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Return empty .json() object on 204. Fix #165. (#166)" #201

Merged
merged 1 commit into from
Nov 26, 2016
Merged

Conversation

TimothyGu
Copy link
Collaborator

@TimothyGu TimothyGu commented Nov 23, 2016

This reverts commit 95b5893.

Fixes #165.

This reverts commit 95b5893.

Fixes #165.

Conflicts:
	CHANGELOG.md
	lib/body.js
	test/server.js
	test/test.js
@TimothyGu TimothyGu merged commit d3071fa into v2 Nov 26, 2016
@TimothyGu TimothyGu deleted the v2-json branch November 26, 2016 17:07
@TimothyGu TimothyGu modified the milestone: Version 2.0.0 Dec 6, 2016
@hmarr
Copy link

hmarr commented May 22, 2017

Hello! Any chance this could be back-ported to a 1.x.x release? Not throwing the error broke compatibility with browser fetch implementations, so I'd consider this commit a fix that gets us back to the previous desired behaviour.

Thanks!

@bitinn
Copy link
Collaborator

bitinn commented May 22, 2017 via email

@hmarr
Copy link

hmarr commented May 23, 2017

Ok, thanks @bitinn. What's the ETA for a 2.0 final release?

I'm using node-fetch via fetch-mock, which depends on 1.x, and I imagine they'd want to wait for a non-prerelease of v2 before upgrading.

If it's going to be a while off, I'll put in a PR for 1.x doing the backport.

@bitinn
Copy link
Collaborator

bitinn commented May 24, 2017

@hmarr actually I have already fixed it in recent v1.7.0 release :)

@hmarr
Copy link

hmarr commented May 24, 2017

@bitinn brilliant, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants