-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HIDAsync & expand getdeviceinfo #506
Conversation
@todbot this fixes those macos compiler warnings. I realised that I didnt update the readme as part of this, which I shall do now And typescript typings got included in this PR too for some reason. Do you mind them being here, or would you rather they were kept elsewhere like they are for other version? https://github.com/Julusian/node-hid/blob/feat/hid-async-v2/nodehid.d.ts |
@todbot any chance of getting this merged soon if I fix the merge conflict? |
Yes! Let's try it out and I'll test existing code against the hardware I have. Thank you for your patience. |
Github lied about a merge conflict, so it is ready now. A couple of months ago, I pushed this live to beta builds of Companion. Based on the analytics we have, that means this code is with ~1500 users (that are connected to the internet, there are likely more who are not online), a majority of who will be using a streamdeck (or possibly an xkeys, or a couple of other hid devices). I would also like to get #507 merged too if possible, |
Initial tests look good. Thank you so much. |
Retrying #474 #499