fix: emit agent socket close event

node-modules · Dec 19, 2016 · 8c83f0f · 8c83f0f
1 parent c3c9550
commit 8c83f0f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/lib/_http_agent.js b/lib/_http_agent.js
@@ -278,6 +278,10 @@ Agent.prototype.createSocket = function createSocket(req, options, cb) {
       // If you want to remove a socket from the pool, just close it.
       // All socket errors end in a close event anyway.
       self.removeSocket(s, options);
+
+      // [patch start]
+      self.emit('close');
+      // [patch end]
     }
     s.on('close', onClose);
 

diff --git a/lib/agent.js b/lib/agent.js
@@ -54,7 +54,6 @@ class Agent extends OriginalAgent {
       this.closeSocketCount++;
     });
     this.on('error', () => {
-      console.log('error socket', arguments);
       this.errorSocketCount++;
     });
   }

diff --git a/test/agent.test.js b/test/agent.test.js
@@ -229,9 +229,14 @@ describe('test/agent.test.js', () => {
   });
 
   it('should remove keepalive socket when server side destroy()', done => {
+    done = pedding(2, done);
     const name = 'localhost:' + port + ':';
     assert(!agentkeepalive.sockets[name]);
     assert(agentkeepalive.freeSockets[name].length === 1);
+
+    // should emit agent close event too
+    agentkeepalive.once('close', done);
+
     const req = http.get({
       agent: agentkeepalive,
       port,