Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: timeout support humanize ms #48

Merged
merged 1 commit into from Feb 20, 2017
Merged

feat: timeout support humanize ms #48

merged 1 commit into from Feb 20, 2017

Conversation

dead-horse
Copy link
Member

No description provided.

@mention-bot
Copy link

@dead-horse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @pangorgo and @pmalouin to be potential reviewers.

@codecov-io
Copy link

Codecov Report

Merging #48 into master will decrease coverage by -1.89%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   92.82%   90.94%   -1.89%     
==========================================
  Files           4        4              
  Lines         251      254       +3     
==========================================
- Hits          233      231       -2     
- Misses         18       23       +5
Impacted Files Coverage Δ
lib/agent.js 93.33% <100%> (+0.47%)
lib/_http_agent.js 89.63% <ø> (-2.6%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe733e7...582c50f. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #48 into master will decrease coverage by -1.89%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   92.82%   90.94%   -1.89%     
==========================================
  Files           4        4              
  Lines         251      254       +3     
==========================================
- Hits          233      231       -2     
- Misses         18       23       +5
Impacted Files Coverage Δ
lib/agent.js 93.33% <100%> (+0.47%)
lib/_http_agent.js 89.63% <ø> (-2.6%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe733e7...582c50f. Read the comment docs.

@fengmk2
Copy link
Member

fengmk2 commented Feb 20, 2017

+1

@fengmk2 fengmk2 merged commit d0b9b18 into master Feb 20, 2017
@fengmk2 fengmk2 deleted the support-humanize-ms branch February 20, 2017 03:51
@fengmk2
Copy link
Member

fengmk2 commented Feb 20, 2017

3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants