New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ipv6 addresses in host-header correctly with TLS #53

Merged

fengmk2 merged 5 commits into node-modules:master from mattiash:issue-52-ipv6-tls

Mar 8, 2018

Commits on Mar 6, 2018

Add ca certificate and check that certs are valid

mattiasholmlund committed Mar 6, 2018

Copy the full SHA

226292c View commit details

Browse the repository at this point in the history

Handle ipv6 addresses in host-header correctly with TLS

When a url uses an ipv6-addresses as the host part, the host-header of the request will be

[::1]:3000

(for ipv6 address ::1). To verify the IP address against a TLS certificate, we need to extract the
IP-address correctly.

Requires node with nodejs/node#14736 resolved to work.

mattiasholmlund committed Mar 6, 2018

Add tests for certificates with ipv6 addresses

mattiasholmlund committed Mar 6, 2018

Copy the full SHA

5b544a5 View commit details

Browse the repository at this point in the history

Commits on Mar 7, 2018

Fix check for supported node version

mattiasholmlund committed Mar 7, 2018

Copy the full SHA

877cb40 View commit details

Browse the repository at this point in the history
Skip test if ipv6 is not available

mattiasholmlund committed Mar 7, 2018

Copy the full SHA

375fc7d View commit details

Browse the repository at this point in the history