Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run test on node 10 #63

Merged
merged 3 commits into from Jul 11, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .autod.conf
Expand Up @@ -20,5 +20,7 @@ module.exports = {
],
semver: [
'egg-bin@1',
'eslint@4',
'eslint-config-egg@6',
],
};
3 changes: 1 addition & 2 deletions .travis.yml
@@ -1,11 +1,10 @@
sudo: false
language: node_js
node_js:
- '4.3.2'
- '4'
- '6'
- '8'
- '9'
- '10'
install:
- npm i npminstall && npminstall
script:
Expand Down
3 changes: 1 addition & 2 deletions appveyor.yml
@@ -1,10 +1,9 @@
environment:
matrix:
- nodejs_version: '4.3.2'
- nodejs_version: '4'
- nodejs_version: '6'
- nodejs_version: '8'
- nodejs_version: '9'
- nodejs_version: '10'

install:
- ps: Install-Product node $env:nodejs_version
Expand Down
12 changes: 1 addition & 11 deletions benchmark/proxy.js
@@ -1,14 +1,4 @@
/*!
* agentkeepalive - benchmark/proxy.js
* Copyright(c) 2012 fengmk2 <fengmk2@gmail.com>
* MIT Licensed
*/

"use strict";

/**
* Module dependencies.
*/
'use strict';

var http = require('http');
var AgentKeepalive = require('../');
Expand Down
12 changes: 6 additions & 6 deletions package.json
Expand Up @@ -34,18 +34,18 @@
"humanize-ms": "^1.2.1"
},
"devDependencies": {
"autod": "^2.8.0",
"egg-bin": "^1.10.3",
"egg-ci": "^1.7.0",
"eslint": "^3.19.0",
"eslint-config-egg": "^4.2.0",
"autod": "^3.0.1",
"egg-bin": "^1.11.1",
"egg-ci": "^1.8.0",
"eslint": "^4.19.1",
"eslint-config-egg": "^6.0.0",
"pedding": "^1.1.0"
},
"engines": {
"node": ">= 4.0.0"
},
"ci": {
"version": "4.3.2, 4, 6, 8, 9"
"version": "4, 6, 8, 10"
},
"author": "fengmk2 <fengmk2@gmail.com> (https://fengmk2.com)",
"license": "MIT"
Expand Down
18 changes: 9 additions & 9 deletions test/agent.test.js
Expand Up @@ -938,10 +938,10 @@ describe('test/agent.test.js', () => {
}, () => {
throw new Error('should not run this');
})
.on('error', () => {
assert(agentkeepalive.sockets[name].length === 1);
done();
});
.on('error', () => {
assert(agentkeepalive.sockets[name].length === 1);
done();
});

http.get({
agent: agentkeepalive,
Expand All @@ -950,9 +950,9 @@ describe('test/agent.test.js', () => {
}, () => {
throw new Error('should not run this');
})
.on('error', () => {
.on('error', () => {
// do noting
});
});

http.get({
agent: agentkeepalive,
Expand All @@ -961,9 +961,9 @@ describe('test/agent.test.js', () => {
}, () => {
throw new Error('should not run this');
})
.on('error', () => {
// do noting
});
.on('error', () => {
// do noting
});

assert(Object.keys(agentkeepalive.sockets).length === 1);
});
Expand Down