Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reusedSocket property on client request #82

Merged
merged 1 commit into from Oct 12, 2019

Conversation

starkwang
Copy link
Contributor

Node.js core has landed the implementation of request.reusedSocket on master. This change is to add the same property on agentkeepalive, which makes this feature can be used through agentkeepalive in older version of Node.js.

Refs: nodejs/node#29715

@codecov
Copy link

codecov bot commented Oct 12, 2019

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #82   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         174    176    +2     
=====================================
+ Hits          174    176    +2
Impacted Files Coverage Δ
lib/agent.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ba744...2313eb8. Read the comment docs.

@fengmk2
Copy link
Member

fengmk2 commented Oct 12, 2019

@starkwang Great feature for the httpclient.

@fengmk2 fengmk2 merged commit fe33b80 into node-modules:master Oct 12, 2019
@fengmk2
Copy link
Member

fengmk2 commented Oct 12, 2019

4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants