Use ESLint and compatible with `.jshintrc` #1338

gucong3000 · 2017-07-28T06:05:17Z

.eslintrc.json is compatible with .jshintrc.
Fixing lint errors on precommit.
All errors written before 2017-8-2 will be ignored.
Fixed: generate/templates/templates/nodegit.js

# Conflicts: # generate/templates/templates/nodegit.js

gucong3000 · 2017-08-03T10:50:37Z

This PR provides a smooth transition from jshint to eslint solutions.
Then we can gradually enhance the eslint rules without affecting the existing code.

gucong3000 · 2017-08-09T06:24:42Z

Right now it is the most popular ES linter.

implausible

I'd prefer not to bring in gulp for this. Doesn't eslint provide good, descriptive output without gulp-reporter? Can we not use eslint via cmd line?

implausible · 2017-08-16T15:17:44Z

generate/templates/templates/nodegit.js

@@ -1,3 +1,5 @@
+/* eslint no-unused-vars: "off" */


Should we be worried about linting this generated file?

What is your plan about this? How about just remove this line?

Disable lint from the entire file imo. Perhaps we could have a post generate linter?

gucong3000 · 2017-08-17T02:02:49Z

A Comparison of JavaScript Linting Tools

implausible · 2017-08-17T03:30:27Z

So I have no qualms with using eslint, but I don't want to bring in any gulp packages. You'll need to update your push to use eslint on the CLI.

gucong3000 · 2017-08-17T04:00:03Z

$ eslint lib test/tests test/utils examples lifecycleScripts

E:\work\nodegit\lib\commit.js
  28:66  error  'callback' is defined but never used  no-unused-vars

E:\work\nodegit\lib\repository.js
   640:65  error  'callback' is defined but never used  no-unused-vars
  1156:53  error  'payload' is defined but never used   no-unused-vars

E:\work\nodegit\lib\tree_entry.js
  92:37  error  'callback' is defined but never used  no-unused-vars

E:\work\nodegit\lib\tree.js
  126:32  error  'blobsOnly' is defined but never used   no-unused-vars
  162:45  error  'entryIndex' is defined but never used  no-unused-vars

E:\work\nodegit\test\tests\branch.js
  115:22  error  'branch' is defined but never used  no-unused-vars
  118:19  error  'error' is defined but never used   no-unused-vars
  153:22  error  'branch' is defined but never used  no-unused-vars
  156:19  error  'error' is defined but never used   no-unused-vars

E:\work\nodegit\test\tests\checkout.js
   31:20  error  'blob' is defined but never used    no-unused-vars
  126:20  error  'branch' is defined but never used  no-unused-vars
  149:20  error  'commit' is defined but never used  no-unused-vars

E:\work\nodegit\test\tests\clone.js
   67:38  error  'progress' is defined but never used  no-unused-vars
  108:40  error  'progress' is defined but never used  no-unused-vars
  146:34  error  'progress' is defined but never used  no-unused-vars
  346:23  error  'reason' is defined but never used    no-unused-vars

E:\work\nodegit\test\tests\commit.js
   33:52  error  'commitMessage' is defined but never used       no-unused-vars
  391:35  error  'commit' is defined but never used              no-unused-vars
  402:34  error  'err' is defined but never used                 no-unused-vars
  464:41  error  'entry' is defined but never used               no-unused-vars
  472:39  error  'entries' is defined but never used             no-unused-vars
  679:9   error  'signature' is assigned a value but never used  no-unused-vars

E:\work\nodegit\test\tests\config.js
  51:24  error  'e' is defined but never used  no-unused-vars

E:\work\nodegit\test\tests\diff.js
  232:33  error  'payload' is defined but never used  no-unused-vars
  265:33  error  'payload' is defined but never used  no-unused-vars

E:\work\nodegit\test\tests\filter.js
  160:24  error  'result' is defined but never used  no-unused-vars
  270:23  error  'error' is defined but never used   no-unused-vars
  464:35  error  'source' is defined but never used  no-unused-vars
  510:35  error  'source' is defined but never used  no-unused-vars
  512:28  error  'buf' is defined but never used     no-unused-vars
  516:30  error  'attr' is defined but never used    no-unused-vars
  551:35  error  'source' is defined but never used  no-unused-vars
  553:28  error  'buf' is defined but never used     no-unused-vars
  557:30  error  'attr' is defined but never used    no-unused-vars
  593:35  error  'source' is defined but never used  no-unused-vars
  595:28  error  'buf' is defined but never used     no-unused-vars
  599:30  error  'attr' is defined but never used    no-unused-vars
  621:24  error  'oid' is defined but never used     no-unused-vars
  650:35  error  'source' is defined but never used  no-unused-vars
  652:28  error  'buf' is defined but never used     no-unused-vars
  656:30  error  'attr' is defined but never used    no-unused-vars
  679:24  error  'oid' is defined but never used     no-unused-vars

E:\work\nodegit\test\tests\merge.js
   146:9   error  'theirCommit' is assigned a value but never used  no-unused-vars
   147:9   error  'ourBranch' is assigned a value but never used    no-unused-vars
   262:9   error  'theirCommit' is assigned a value but never used  no-unused-vars
   263:9   error  'ourBranch' is assigned a value but never used    no-unused-vars
   384:9   error  'ourCommit' is assigned a value but never used    no-unused-vars
   385:9   error  'theirCommit' is assigned a value but never used  no-unused-vars
   534:11  error  'ourCommit' is assigned a value but never used    no-unused-vars
   535:11  error  'theirCommit' is assigned a value but never used  no-unused-vars
   691:11  error  'ourCommit' is assigned a value but never used    no-unused-vars
   692:11  error  'theirCommit' is assigned a value but never used  no-unused-vars
   844:9   error  'theirCommit' is assigned a value but never used  no-unused-vars
   845:9   error  'ourBranch' is assigned a value but never used    no-unused-vars
   963:9   error  'ourCommit' is assigned a value but never used    no-unused-vars
   964:9   error  'theirCommit' is assigned a value but never used  no-unused-vars
  1110:9   error  'ourCommit' is assigned a value but never used    no-unused-vars
  1111:9   error  'theirCommit' is assigned a value but never used  no-unused-vars

E:\work\nodegit\test\tests\note.js
  62:14  error  'noteSha' is defined but never used  no-unused-vars

E:\work\nodegit\test\tests\rebase.js
    77:28  error  'branch' is defined but never used  no-unused-vars
   476:22  error  'oid' is defined but never used     no-unused-vars
   728:28  error  'branch' is defined but never used  no-unused-vars
  1341:22  error  'oid' is defined but never used     no-unused-vars

E:\work\nodegit\test\tests\remote.js
  285:40  error  'userName' is defined but never used  no-unused-vars
  321:40  error  'userName' is defined but never used  no-unused-vars

E:\work\nodegit\test\tests\repository.js
  64:28  error  'isBare' is defined but never used  no-unused-vars

E:\work\nodegit\test\tests\revwalk.js
  111:11  error  'storedCommits' is assigned a value but never used  no-unused-vars

E:\work\nodegit\test\tests\signature.js
  94:9  error  'time' is assigned a value but never used  no-unused-vars

E:\work\nodegit\test\tests\stash.js
  148:11  error  'oldContent' is assigned a value but never used  no-unused-vars
  179:11  error  'oldContent' is assigned a value but never used  no-unused-vars

E:\work\nodegit\test\utils\index_setup.js
  66:22  error  'commitOid' is defined but never used  no-unused-vars

E:\work\nodegit\examples\index-add-and-remove.js
  91:26  error  'matchedPattern' is defined but never used  no-unused-vars

implausible

I don't think I'm getting my point across, so here are the packages I don't want to bring into NodeGit. All of the scripts you wrote that are using these packages can be written without the use of any gulp utilities.

implausible · 2017-08-17T15:53:27Z

package.json

@@ -48,11 +48,17 @@
    "clean-for-publish": "~1.0.2",
    "combyne": "~0.8.1",
    "coveralls": "~2.11.4",
+    "eslint": "^4.4.1",
+    "gulp-debug": "^3.1.0",


I don't want this package in NodeGit.

implausible · 2017-08-17T15:53:33Z

package.json

@@ -48,11 +48,17 @@
    "clean-for-publish": "~1.0.2",
    "combyne": "~0.8.1",
    "coveralls": "~2.11.4",
+    "eslint": "^4.4.1",
+    "gulp-debug": "^3.1.0",
+    "gulp-eslint": "^4.0.0",


I don't want this package in NodeGit.

implausible · 2017-08-17T15:53:37Z

package.json

+    "eslint": "^4.4.1",
+    "gulp-debug": "^3.1.0",
+    "gulp-eslint": "^4.0.0",
+    "gulp-reporter": "^2.2.1",


I don't want this package in NodeGit.

implausible · 2017-08-17T15:53:48Z

package.json

+    "gulp-debug": "^3.1.0",
+    "gulp-eslint": "^4.0.0",
+    "gulp-reporter": "^2.2.1",
+    "husky": "^0.14.3",


What is this package for?

gucong3000 · 2017-09-01T03:19:12Z

Can we not use eslint via cmd line?

It will make so many error.

cjhoward92 · 2017-12-20T16:29:52Z

@gucong3000 By saying eslint will cause many errors do you mean linter errors or something else breaks? If it is just linter errors the eslint rules should be modified to work with the existing rules, correct?

wmertens · 2021-03-07T12:59:46Z

FYI, I didn't notice this PR, I also made one that adds ESLint but without gulp. #1825

Add eslint

bb701d9

gucong3000 changed the title ~~Use ESLint with compatible with .jshintrc~~ Use ESLint and compatible with .jshintrc Jul 28, 2017

gucong3000 changed the title ~~Use ESLint and compatible with .jshintrc~~ [WIP] Use ESLint and compatible with .jshintrc Jul 28, 2017

刘祺 added 3 commits July 28, 2017 14:59

debug

5b0ad5f

test for gulp-reporter v2.1.1

afacad7

update gulp-reporter

8a74117

gucong3000 changed the title ~~[WIP] Use ESLint and compatible with .jshintrc~~ Use ESLint and compatible with .jshintrc Jul 28, 2017

gucong3000 and others added 4 commits July 29, 2017 01:10

Merge branch 'master' into eslint

5b821c6

set eslint expires date to 2017-7-31

420e582

Merge branch 'master' into eslint

8956216

# Conflicts: # generate/templates/templates/nodegit.js

update eslint err fail date config

d51f877

gucong3000 closed this Aug 3, 2017

gucong3000 reopened this Aug 3, 2017

刘祺 added 3 commits August 14, 2017 10:37

update deps

c6f6d40

lint by git flow

aa8356d

update npm scripts

66297aa

implausible requested changes Aug 16, 2017

View reviewed changes

Merge branch 'master' into eslint

3048c86

implausible requested changes Aug 17, 2017

View reviewed changes

implausible force-pushed the master branch from c345989 to c67b436 Compare August 26, 2019 22:49

implausible force-pushed the master branch from 2b7db46 to 69b010a Compare July 28, 2020 17:26

ChristianMurphy mentioned this pull request Sep 3, 2020

migrate jshint to eslint #1791

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ESLint and compatible with `.jshintrc` #1338

Use ESLint and compatible with `.jshintrc` #1338

gucong3000 commented Jul 28, 2017 •

edited

gucong3000 commented Aug 3, 2017 •

edited

gucong3000 commented Aug 9, 2017

implausible left a comment

implausible Aug 16, 2017

gucong3000 Aug 16, 2017

implausible Aug 17, 2017

gucong3000 commented Aug 17, 2017

implausible commented Aug 17, 2017

gucong3000 commented Aug 17, 2017

implausible left a comment •

edited

implausible Aug 17, 2017

implausible Aug 17, 2017

implausible Aug 17, 2017

implausible Aug 17, 2017

gucong3000 commented Sep 1, 2017 •

edited

cjhoward92 commented Dec 20, 2017

wmertens commented Mar 7, 2021

Use ESLint and compatible with .jshintrc #1338

Are you sure you want to change the base?

Use ESLint and compatible with .jshintrc #1338

Conversation

gucong3000 commented Jul 28, 2017 • edited

gucong3000 commented Aug 3, 2017 • edited

gucong3000 commented Aug 9, 2017

implausible left a comment

Choose a reason for hiding this comment

implausible Aug 16, 2017

Choose a reason for hiding this comment

gucong3000 Aug 16, 2017

Choose a reason for hiding this comment

implausible Aug 17, 2017

Choose a reason for hiding this comment

gucong3000 commented Aug 17, 2017

implausible commented Aug 17, 2017

gucong3000 commented Aug 17, 2017

implausible left a comment • edited

Choose a reason for hiding this comment

implausible Aug 17, 2017

Choose a reason for hiding this comment

implausible Aug 17, 2017

Choose a reason for hiding this comment

implausible Aug 17, 2017

Choose a reason for hiding this comment

implausible Aug 17, 2017

Choose a reason for hiding this comment

gucong3000 commented Sep 1, 2017 • edited

cjhoward92 commented Dec 20, 2017

wmertens commented Mar 7, 2021

Use ESLint and compatible with `.jshintrc` #1338

Use ESLint and compatible with `.jshintrc` #1338

gucong3000 commented Jul 28, 2017 •

edited

gucong3000 commented Aug 3, 2017 •

edited

implausible left a comment •

edited

gucong3000 commented Sep 1, 2017 •

edited